Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Don't warn if target reports no threads
Date: Tue, 19 Oct 2010 14:52:00 -0000	[thread overview]
Message-ID: <201010191852.03421.vladimir@codesourcery.com> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 367 bytes --]


In the case when stub refuses to understand all modern thread-listing packets,
GDB falls back to qL packet, if if stub refuses to handle that either, 
reports:

	RMT ERROR : failed to get remote thread list.

The further operation continues normally, and qL is really optional packet, so
there's no point scaring a user like that. Is the patch below OK?

- Volodya


[-- Attachment #2: rmt-no-warning.diff --]
[-- Type: text/x-patch, Size: 366 bytes --]

diff --git a/gdb/remote.c b/gdb/remote.c
index 50e671d..e3c4117 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2523,7 +2523,6 @@ remote_get_threadlist (int startflag, threadref *nextthread, int result_limit,
     {
       if (*done != 1)
 	{
-	  warning (_("RMT ERROR : failed to get remote thread list."));
 	  result = 0;
 	}
       return result;		/* break; */

             reply	other threads:[~2010-10-19 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 14:52 Vladimir Prus [this message]
2010-10-19 15:01 ` Pedro Alves
2010-10-20  9:11   ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010191852.03421.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox