From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6792 invoked by alias); 19 Oct 2010 15:01:34 -0000 Received: (qmail 6740 invoked by uid 22791); 19 Oct 2010 15:01:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Oct 2010 15:01:29 +0000 Received: (qmail 19051 invoked from network); 19 Oct 2010 15:01:27 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Oct 2010 15:01:27 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Don't warn if target reports no threads Date: Tue, 19 Oct 2010 15:01:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Vladimir Prus References: <201010191852.03421.vladimir@codesourcery.com> In-Reply-To: <201010191852.03421.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201010191601.26042.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00294.txt.bz2 On Tuesday 19 October 2010 15:52:03, Vladimir Prus wrote: > > In the case when stub refuses to understand all modern thread-listing packets, > GDB falls back to qL packet, if if stub refuses to handle that either, > reports: > > RMT ERROR : failed to get remote thread list. > > The further operation continues normally, and qL is really optional packet, so > there's no point scaring a user like that. Is the patch below OK? remote_get_threadlist has this: getpkt (&rs->buf, &rs->buf_size, 0); if (*rs->buf == '\0') *result_count = 0; else ... would it work to just make that: if (*rs->buf == '\0') return 0; instead? That'd be easier to read, and leave the warning if something did go bust with the thread listing for targets that do support the packet (not sure there are any though). -- Pedro Alves