Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] linux-nat: Never PTRACE_CONT a stepping thread
Date: Mon, 18 Oct 2010 08:51:00 -0000	[thread overview]
Message-ID: <20101018085138.GA25628@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201010172004.18986.pedro@codesourcery.com>

On Sun, 17 Oct 2010 21:04:18 +0200, Pedro Alves wrote:
> I just belatedly realized that this probably
> breaks software single-step archs though.  :-/

I have run the testsuite on arm-fedora12-linux-gnu and the only
regression-candidate there is gdb.threads/local-watch-wrong-thread.exp .

But that one is reproducible even on x86_64-fedora14snapshot-linux-gnu just by
`set can-use-hw-watchpoints 0'.  That testcase in fact should not have
executed on arm due to:
	if [target_info exists gdb,no_hardware_watchpoints] { return 0; }

Checking more why that change happened.

I do not see why it should fail in general.  insert_single_step_breakpoint
already supports two existing single step breakpoints, one gets used for
inferior_ptid and one for stepping ptid.  Maybe the support of two single step
breakpoints is there for some inferior code constructs, in such case
I understand two would be no longer enough.


Thanks,
Jan


  reply	other threads:[~2010-10-18  8:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22  9:43 Jan Kratochvil
2010-10-16 17:10 ` Pedro Alves
2010-10-17 18:28   ` Jan Kratochvil
2010-10-17 19:04     ` Pedro Alves
2010-10-18  8:51       ` Jan Kratochvil [this message]
2010-10-19 19:24         ` Pedro Alves
2010-11-02  1:56           ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101018085138.GA25628@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox