Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Stan Shebs <stan@codesourcery.com>,	Pedro Alves <pedro@codesourcery.com>
Subject: [RFA] Quiet a tracepoint notification with gdbserver
Date: Fri, 08 Oct 2010 17:41:00 -0000	[thread overview]
Message-ID: <20101008174145.GP23776@caradoc.them.org> (raw)

Since gdbserver now defines trace_timestamp, we get a notice after
connection.  This is confusing if you're not trying to use
tracepoints.  I suggest the attached patch; OK?

-- 
Daniel Jacobowitz
CodeSourcery

2010-10-08  Daniel Jacobowitz  <dan@codesourcery.com>

	* tracepoint.c (merge_uploaded_trace_state_variables): Only print
	messages if info_verbose.

Index: tracepoint.c
===================================================================
--- tracepoint.c	(revision 301900)
+++ tracepoint.c	(working copy)
@@ -3139,13 +3139,17 @@ merge_uploaded_trace_state_variables (st
     {
       tsv = find_matching_tsv (utsv);
       if (tsv)
-	printf_filtered (_("Assuming trace state variable $%s is same as target's variable %d.\n"),
-			 tsv->name, utsv->number);
+	{
+	  if (info_verbose)
+	    printf_filtered (_("Assuming trace state variable $%s is same as target's variable %d.\n"),
+			     tsv->name, utsv->number);
+	}
       else
 	{
 	  tsv = create_tsv_from_upload (utsv);
-	  printf_filtered (_("Created trace state variable $%s for target's variable %d.\n"),
-			   tsv->name, utsv->number);
+	  if (info_verbose)
+	    printf_filtered (_("Created trace state variable $%s for target's variable %d.\n"),
+			     tsv->name, utsv->number);
 	}
       /* Give precedence to numberings that come from the target.  */
       if (tsv)


             reply	other threads:[~2010-10-08 17:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 17:41 Daniel Jacobowitz [this message]
2010-10-08 17:49 ` Michael Snyder
2010-10-08 18:52 ` Stan Shebs
2010-10-08 20:45   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008174145.GP23776@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=stan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox