From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6852 invoked by alias); 8 Oct 2010 13:27:04 -0000 Received: (qmail 6838 invoked by uid 22791); 8 Oct 2010 13:27:03 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.17.167) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Oct 2010 13:26:57 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.1/8.13.1) with ESMTP id o98DQtwI025396 for ; Fri, 8 Oct 2010 13:26:55 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o98DQtGR4042808 for ; Fri, 8 Oct 2010 15:26:55 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o98DQs55028003 for ; Fri, 8 Oct 2010 15:26:55 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o98DQrBJ027948; Fri, 8 Oct 2010 15:26:53 +0200 Message-Id: <201010081326.o98DQrBJ027948@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 08 Oct 2010 15:26:53 +0200 Subject: Re: [rfa, v3] Fix software-watchpoint failures on ARM by adding epilogue detection To: rearnsha@arm.com (Richard Earnshaw) Date: Fri, 08 Oct 2010 13:27:00 -0000 From: "Ulrich Weigand" Cc: dan@codesourcery.com (Daniel Jacobowitz), gdb-patches@sourceware.org In-Reply-To: <1286542864.29651.13.camel@e102346-lin.cambridge.arm.com> from "Richard Earnshaw" at Oct 08, 2010 02:01:04 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00136.txt.bz2 Richard Earnshaw wrote: > On Thu, 2010-10-07 at 18:12 +0200, Ulrich Weigand wrote: > > 2010-10-07 Ulrich Weigand > > Daniel Jacobowitz > > > > * arm-tdep.c (thumb_in_function_epilogue_p) > > (arm_in_function_epilogue_p): New. > > (arm_gdbarch_init): Install arm_in_function_epilogue_p as > > gdbarch_in_function_epilogue_p callback. > > > > This is OK. There are some sequences that could be generated that this > can't handle, and I don't think we'd ever get a stack decrement in an > epilogue sequence. > > An example I don't think your code can handle is stack adjustments that > are not valid immediates for ADD SP, #n. So very large stack adjusts my > fail. These sequences will load or create an immediate in a register > (particularly on Thumb1) and then add that to SP. Thanks for the review; I've checked the patch in now. We can always go back and add more instructions later ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com