From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21292 invoked by alias); 6 Oct 2010 23:34:05 -0000 Received: (qmail 21192 invoked by uid 22791); 6 Oct 2010 23:34:04 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 23:33:59 +0000 Received: (qmail 1148 invoked from network); 6 Oct 2010 23:33:57 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Oct 2010 23:33:57 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] regression: Fix in-tree build [Re: [patch] Create general staging area for data-directory files.] Date: Wed, 06 Oct 2010 23:34:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil , Doug Evans References: <20101005001819.ECC65764B8@ruffy.mtv.corp.google.com> <20101006232415.GA18635@host1.dyn.jankratochvil.net> In-Reply-To: <20101006232415.GA18635@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201010070033.52366.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00101.txt.bz2 On Thursday 07 October 2010 00:24:15, Jan Kratochvil wrote: > On Tue, 05 Oct 2010 02:18:19 +0200, Doug Evans wrote: > > --- /dev/null 2010-09-23 16:28:04.543730915 -0700 > > +++ data-directory/Makefile.in 2010-10-04 16:56:01.000000000 -0700 > > +Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status @frags@ > > + cd $(top_builddir) && $(MAKE) data-directory/Makefile > Does this need to depend on @frags@ in the first place? > -> > Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status ./config/i386/linux64.mh > > cd /home/...; ./configure; make > [...] > make[4]: Entering directory `/home/.../gdb/data-directory' > make[4]: *** No rule to make target `config/i386/linux64.mh', needed by `Makefile'. Stop. > > I will be away for a day, please check it in if it looks OK. > > > Thanks, > Jan > > > gdb/ > 2010-10-07 Jan Kratochvil > > * Makefile.in (top_srcdir): New substituted variable. > * configure.ac: New variable host_makefile_frag_1. Use $(top_srcdir) > prefix for @frags@. > * configure: Regenerate. > > --- ./gdb/Makefile.in 2010-10-06 18:46:12.000000000 +0200 > +++ ./gdb/Makefile.in 2010-10-07 00:55:59.000000000 +0200 > @@ -97,6 +97,7 @@ POSTCOMPILE = @true > > # Directory containing source files. > srcdir = @srcdir@ > +top_srcdir = @top_srcdir@ > VPATH = @srcdir@ > > YACC=@YACC@ > --- ./gdb/configure.ac 2010-10-06 18:02:43.000000000 +0200 > +++ ./gdb/configure.ac 2010-10-07 00:57:59.000000000 +0200 > @@ -2046,11 +2046,13 @@ AC_SUBST(target_subdir) > > frags= > if test "${gdb_native}" = "yes"; then > - host_makefile_frag=${srcdir}/config/${gdb_host_cpu}/${gdb_host}.mh > + host_makefile_frag_1=config/${gdb_host_cpu}/${gdb_host}.mh > + host_makefile_frag=${srcdir}/${host_makefile_frag_1} > if test ! -f ${host_makefile_frag}; then > AC_MSG_ERROR("*** Gdb does not support native target ${host}") > fi > - frags="$frags $host_makefile_frag" > + # @frags@ may be used in a different subdirectory - use $(top_srcdir). > + frags="$frags \$(top_srcdir)/$host_makefile_frag_1" > else > host_makefile_frag=/dev/null > fi > -- Pedro Alves