From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14171 invoked by alias); 6 Oct 2010 23:18:05 -0000 Received: (qmail 14163 invoked by uid 22791); 6 Oct 2010 23:18:05 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 23:17:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4884C2BAC41; Wed, 6 Oct 2010 19:17:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3Y1riPRgjLup; Wed, 6 Oct 2010 19:17:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 186842BAC3D; Wed, 6 Oct 2010 19:17:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4BC16F5895; Wed, 6 Oct 2010 16:17:55 -0700 (PDT) Date: Wed, 06 Oct 2010 23:18:00 -0000 From: Joel Brobecker To: Paul Hilfinger Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Extend hashed symbol dictionaries to work with Ada Message-ID: <20101006231755.GB12651@adacore.com> References: <201010050820.o958Kf42002588@syracuse.mckusick.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201010050820.o958Kf42002588@syracuse.mckusick.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00098.txt.bz2 > gdb/ > * ada-lang.c (ada_match_name): Use new API for wild_match. > (wild_match): Change API to be consistent with that of strcmp_iw; > return 0 for a match, and switch operand order. > (full_match): New function. > (ada_add_block_symbols): Use dict_iter_match_{first,next} for > matching to allow use of hashing. No further comment on this part (I actually had already looked at these patches, but did not feel comfortable approving them myself for the non-Ada parts). Thanks again, Tom, for looking at the rest. -- Joel