From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gpeKHqWzzWbXJBYAWB0awg (envelope-from ) for ; Tue, 27 Aug 2024 07:08:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K/GU+1WE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6824E1E0D0; Tue, 27 Aug 2024 07:08:21 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 516191E08C for ; Tue, 27 Aug 2024 07:08:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 05FA3385E44D for ; Tue, 27 Aug 2024 11:08:19 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 98C13385DDDC for ; Tue, 27 Aug 2024 11:07:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98C13385DDDC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 98C13385DDDC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724756878; cv=none; b=uK/YTOEKWAau2KXIvKqLkI3Yj2Npw0cEnDqW9yP46inZdCtsiFVpaqz/e1CGzUyUDlRY8bQzTk7sZ8DzPOuaNQ3S7a2OxfSzbfKR2Thz9JhkKVMVElNr26R+pL2zF9YPemSnt4YsxwAWuTK6E1cQbTATtPs9p3IAaqve2qo1PG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724756878; c=relaxed/simple; bh=4gfbJE6RZWz2nn5HHBgYsLLLySx5mspghMmzKxlTMYE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Zm4Il0SuYUGQLeYst6QExQLaCV0kEEwXN2V35Rz4MvRAAHI95zuyzOgS18ZfAyYbvIudzhiSwjKw3p7yKOm9mJkJgWMShcJVFENDBbEHWRzH4aIQxXb+PvYKtxeqJEyL8lyG20IPD4C3Gc226glx+tSN+CUfDj292ghvb617XrU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724756876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5f3Lo1sBeOMJsx83Zs4RoZYPHMZKnA/JkCeLEp3kdlc=; b=K/GU+1WE4OUSYofvoLvMehsS31lhr0ErPaVmRUM03t7CyWw25/rD8cA6kAZlP6Kt9fboCg CYRCdmbNVg1zX4VmKcKl0/r73mXlq+TryZYlhs2ejTffF1RP8aH70AG33jfgX1Ng/JMRg0 SjZ/0tWUQ6pLRE7KIaKZWzkJOlGPQys= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-GzgIGHiHMdi8KkfcnopM9w-1; Tue, 27 Aug 2024 07:07:55 -0400 X-MC-Unique: GzgIGHiHMdi8KkfcnopM9w-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6bfa9faeadeso61734236d6.0 for ; Tue, 27 Aug 2024 04:07:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724756874; x=1725361674; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5f3Lo1sBeOMJsx83Zs4RoZYPHMZKnA/JkCeLEp3kdlc=; b=HHNIUsHSr9J0qfGAwAJqJz38y3n+0UuJx+5dzP5myFDTJtrNY6FsDTJtdUljFcdQPG +BynbTfArAgL5dEOf0uXyQe+7Z8OiWnIfIcWYwIHOjzt2OG1jAsZ2SXkl4NXpLZR2osJ QYzv4fG7fCKumalrmOYzPZBHu2AdTYbgwG++rp3bJ8TJWciZj9o2fkwFeo8rHxSlQXkt RgvkD45Gur/Kkj+cJDzkqc+C9d1Mi87RIRFl8bfXpnCvOWlSxzVHxocTthBpMKz96ROy 0LXSl3S3M3OOML/n5fAZdN+7JBjvHAt2k4NJz7CIveLVoBurMoVcQoCSgLOhYY7gcdqh ILwA== X-Forwarded-Encrypted: i=1; AJvYcCWFYIznT3RM68WF52z5KaTgCpIWrRNJhc+3KBnWw/sg0PeSK0AmRuq3md3Z1HWGLRIIpomSlih3An/Rsg==@sourceware.org X-Gm-Message-State: AOJu0YxQ4/VLCeb5D3aIPZmcesBznVkhP8spv8UsomScKRkblPy4aoY0 fZ1SIU002phfowdGgZA9U/g5q0n7DS45LI8LAxxx/bToSBWv10isJlfeTMkp4hMw18w6sLBj+m/ +dsaZ18/Maz3DK7UMl+nabAVMa3I2WYyk29xEsfCNaFhkqfG48an88Ut8NUPj/nBIHhg= X-Received: by 2002:a05:6214:5882:b0:6bf:7a30:f438 with SMTP id 6a1803df08f44-6c16dc66793mr146345956d6.22.1724756873948; Tue, 27 Aug 2024 04:07:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMJ1xt6x95eNnqqMvaUs0WGGkJN7UACqHa86yH2mkiLdfLSjmbv+7apzbu2D3yBuadSCmw5g== X-Received: by 2002:a05:6214:5882:b0:6bf:7a30:f438 with SMTP id 6a1803df08f44-6c16dc66793mr146345806d6.22.1724756873640; Tue, 27 Aug 2024 04:07:53 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-454fe1cd19fsm50833261cf.97.2024.08.27.04.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 04:07:53 -0700 (PDT) Message-ID: <20100e5c-74dc-4a09-be7d-1bf94809c3bd@redhat.com> Date: Tue, 27 Aug 2024 08:07:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: Tom de Vries , Alex Chronopoulos , "gdb-patches@sourceware.org" References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> <1d10c73b-0c94-46b5-a1a3-310bb48eed16@redhat.com> <18f1a5da-5581-4dcc-bdf3-2aaf2b161d31@redhat.com> <07bf3284-cdd7-4349-8e42-6d22931b3299@suse.de> From: Guinevere Larsen In-Reply-To: <07bf3284-cdd7-4349-8e42-6d22931b3299@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/27/24 7:17 AM, Tom de Vries wrote: > On 8/26/24 15:41, Guinevere Larsen wrote: >> Pushed :) > > Hi Gwen, > > After this patch got pushed, I ran into: > ... > (gdb) PASS: gdb.btrace/non-stop.exp: no progress: all: thread apply > all continue: prompt > ^M > Reached end of recorded history; stopping.^M > Following forward execution will be added to history.^M > test (arg=0x0) at > /data/vries/gdb/src/gdb/testsuite/gdb.btrace/non-stop.c:30^M > 30        return arg; /* bp.2 */^M > ^M > Reached end of recorded history; stopping.^M > Following forward execution will be added to history.^M > test (arg=0x0) at > /data/vries/gdb/src/gdb/testsuite/gdb.btrace/non-stop.c:30^M > 30        return arg; /* bp.2 */^M > PASS: gdb.btrace/non-stop.exp: no progress: all: thread apply all > continue: thread 0 > FAIL: gdb.btrace/non-stop.exp: no progress: all: thread apply all > continue: thread 1 (timeout) > ... > > I suppose the test-case needs to be updated. The test case is updated. I think the regexes need to be fixed instead. Right now, the test uses: multi_line "reached end of recorded.*Following forward.*" "\[^\\\r\\\n\]*" "\[^\\\r\\\n\]*" the '.*' in the first line must be consuming all of the first output (thread 0) and the next bits are finishing consuming the second input (thread 1), so when expect tries to find the second stop message, it has already been consumed. I'll try to write a more exact version that doesn't do that, but my machine doesn't support btrace so I'll need someone to double check me. -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks, > - Tom >