From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31859 invoked by alias); 30 Sep 2010 17:55:29 -0000 Received: (qmail 31850 invoked by uid 22791); 30 Sep 2010 17:55:27 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Sep 2010 17:55:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 97E622BAC1B; Thu, 30 Sep 2010 13:55:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ly39kq02BBi0; Thu, 30 Sep 2010 13:55:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 643182BABB9; Thu, 30 Sep 2010 13:55:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8E6AFF591F; Thu, 30 Sep 2010 10:55:18 -0700 (PDT) Date: Thu, 30 Sep 2010 18:56:00 -0000 From: Joel Brobecker To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: RFA: shrink main_type Message-ID: <20100930175518.GA2976@adacore.com> References: <20080819051306.GQ16894@adacore.com> <201009151441.43723.ken@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201009151441.43723.ken@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00520.txt.bz2 I'm sorry about the delay in getting to this. I hope it's something temporary that we all seem to be busier than usual. > One approach to restore that functionality would be to move the > nottext flag into to the instance_flags of the type. Attached is an > untested patch of what I have in mind. Comments are welcome. It took me a while to figure out why this is necessary. Initially, I thought that the vector type should have the NOTTEXT bit set, but that wouldn't be sufficient for the case where we just print one element of the vector (because we'd end up checking type of the element and not find the NOTTEXT bit set, and thus print it as a character rather than an integer. Do I understand the situation correctly? If yes, can we add a test that checks that, if not already there? Based on that understanding, then I agree that the NOTTEXT flag seems to be more of an instance flag than a type flag. The code in make_vector_type seems to be confirming that. If you make a proper submission for this patch, I will officially review it. -- Joel