From: Pedro Alves <pedro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add support for GNAT Ravenscar run-time library.
Date: Mon, 27 Sep 2010 19:01:00 -0000 [thread overview]
Message-ID: <201009271843.40237.pedro@codesourcery.com> (raw)
In-Reply-To: <20100927173414.GH3007@adacore.com>
Hi Joel,
This is close, but,
On Monday 27 September 2010 18:34:14, Joel Brobecker wrote:
> @@ -282,6 +286,7 @@ ravenscar_mourn_inferior (struct target_ops *ops)
> base_ptid = null_ptid;
> beneath->to_mourn_inferior (beneath);
> unpush_target (&ravenscar_ops);
> + ravenscar_is_open = 0;
> }
I'd prefer that a ranvenscar target_ops->to_close callback was
implemented, so that if the target ends up closed without going
through mourn_inferior (some paths do that presently):
static void
ravenscar_close (int quitting)
{
ranvenscar_is_open = 0;
}
See for example bsd-uthreads.c:bfd_uthread_close, or
remote-sim.c:gdbsim_close.
This is fine with me with that change.
--
Pedro Alves
next prev parent reply other threads:[~2010-09-27 17:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 19:01 Joel Brobecker
2010-09-23 19:44 ` [PATCH 1/2] [Ada] Add ada-tasks.c:iterate_over_live_ada_tasks Joel Brobecker
2010-09-29 3:25 ` Joel Brobecker
2010-09-23 19:49 ` [PATCH 2/2] Add support for GNAT Ravenscar run-time library Joel Brobecker
2010-09-23 21:56 ` Joel Brobecker
2010-09-23 21:58 ` Jan Kratochvil
2010-09-23 22:09 ` Pedro Alves
2010-09-23 23:39 ` Joel Brobecker
2010-09-24 1:39 ` Pedro Alves
2010-09-27 18:59 ` Joel Brobecker
2010-09-27 19:01 ` Pedro Alves [this message]
2010-09-28 14:55 ` Joel Brobecker
2010-09-29 9:52 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009271843.40237.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox