From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24968 invoked by alias); 23 Sep 2010 22:09:01 -0000 Received: (qmail 24908 invoked by uid 22791); 23 Sep 2010 22:09:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Sep 2010 22:08:57 +0000 Received: (qmail 2748 invoked from network); 23 Sep 2010 22:08:52 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Sep 2010 22:08:52 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [PATCH 2/2] Add support for GNAT Ravenscar run-time library. Date: Fri, 24 Sep 2010 01:39:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org References: <1285267380-8329-1-git-send-email-brobecker@adacore.com> <201009232049.37585.pedro@codesourcery.com> <20100923213927.GD3007@adacore.com> In-Reply-To: <20100923213927.GD3007@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009232308.50387.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00423.txt.bz2 On Thursday 23 September 2010 22:39:27, Joel Brobecker wrote: > +static void > +ravenscar_inferior_created (struct target_ops *target, int from_tty) > +{ > + if (ravenscar_task_support > + && has_ravenscar_runtime () > + && strcmp (target_shortname, ravenscar_ops.to_shortname) != 0) > + ravenscar_initialize (NULL, 0); > +} Please no current/topmost target name comparisons. Add a ravenscar_is_open global if you don't have any other global you can use to check whether target revenscar is open. -- Pedro Alves