Re: [PATCH 2/2] Add support for GNAT Ravenscar run-time library.

Pedro Alves
2010-09-27T17:43:51Z

Hi Joel,

This is close, but,

On Monday 27 September 2010 18:34:14, Joel Brobecker wrote:
> @@ -282,6 +286,7 @@ ravenscar_mourn_inferior (struct target_ops *ops)
> base_ptid = null_ptid;
> beneath->to_mourn_inferior (beneath);
> unpush_target (&ravenscar_ops);
> + ravenscar_is_open = 0;
> }

I'd prefer that a ranvenscar target_ops->to_close callback was
implemented, so that if the target ends up closed without going
through mourn_inferior (some paths do that presently):

static void
ravenscar_close (int quitting)
{
ranvenscar_is_open = 0;
}

See for example bsd-uthreads.c:bfd_uthread_close, or
remote-sim.c:gdbsim_close.

This is fine with me with that change.

--
Pedro Alves