From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 869 invoked by alias); 22 Sep 2010 18:59:16 -0000 Received: (qmail 834 invoked by uid 22791); 22 Sep 2010 18:59:15 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 18:59:10 +0000 Received: (qmail 21942 invoked from network); 22 Sep 2010 18:59:08 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Sep 2010 18:59:08 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PING]RE: [RFA] Fix maint translate command Date: Wed, 22 Sep 2010 19:23:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Joel Brobecker , Pierre Muller References: <002101cb49b3$50d60cd0$f2822670$@muller@ics-cnrs.unistra.fr> <001201cb53e4$3c294e60$b47beb20$@muller@ics-cnrs.unistra.fr> <20100922170111.GE3063@adacore.com> In-Reply-To: <20100922170111.GE3063@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009221959.03816.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00382.txt.bz2 On Wednesday 22 September 2010 18:01:11, Joel Brobecker wrote: > On Tue, Sep 14, 2010 at 10:10:02AM +0200, Pierre Muller wrote: > > The problem of break inside ALL_OBJSECTIONS > > is still not fixed on CVS despite a fix proposed by Pedro? > > > > I must confess that I am unable to fully understand such complicated > > macros, and I leave to others the responsibility to > > approve such kind of patches (I don't have any rights on > > objfiles sources anyhow ...) > > > > Would it be possible to check Pedro's patch in? > > Seems like everyone is really really busy these days :-(. Indeed. :-( > This is coming from Pedro, and I didn't see anything wrong with it. > Since we haven't received any objection, I think it is fine to commit > after running it against the testsuite. I'll test&apply this tomorrow. Sorry for the delay. > > > > I admit it loop ugly, and that may look complicated, but it isn't > > > > (complicated). The outer loop learns about the inner loop's end > > > > condition, and stops iterating if it detects the inner loop didn't > > > > reach it's end. The trick to not clearing "objfile" is to only > > > > advance it in the outer loop, if the inner loop reached it's end. > > I think that this is a useful comment to add to the macro. And perhaps > explain that the purpose is to allow `break' to exit the ALL_OBJSECTIONS > (double-) loop. I'll extend the current comment in that direction. -- Pedro Alves