From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16417 invoked by alias); 22 Sep 2010 19:26:44 -0000 Received: (qmail 16406 invoked by uid 22791); 22 Sep 2010 19:26:43 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 19:26:37 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8MJQar7024140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Sep 2010 15:26:36 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8MJQXvt021478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 Sep 2010 15:26:35 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o8MJQXie029170; Wed, 22 Sep 2010 21:26:33 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o8MJQX2m029169; Wed, 22 Sep 2010 21:26:33 +0200 Date: Wed, 22 Sep 2010 19:51:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] python: load *-gdb.py for shlibs during attach Message-ID: <20100922192633.GA29052@host1.dyn.jankratochvil.net> References: <20100922090919.GA21901@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00389.txt.bz2 On Wed, 22 Sep 2010 21:23:00 +0200, Tom Tromey wrote: > Jan> 2010-09-22 Jan Kratochvil > Jan> * main.c: Include objfiles.h. > Jan> (captured_main): New variable objfile. Call > Jan> load_auto_scripts_for_objfile for ALL_OBJFILES. > > FWIW, I agree this is the right thing to do. BTW what do you think about the case when the called python scripts would manipulate the ALL_OBJFILES list? But even ALL_OBJFILES_SAFE would not be safe enough in such case. Sure it could be protected some other way like to lookup again the saved objfile name. But it can also deadlock. I guess there are more places like that in GDB. Regards, Jan