Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] DWARF: Add support for DW_TAG_constant DIEs
Date: Tue, 21 Sep 2010 18:41:00 -0000	[thread overview]
Message-ID: <20100920160844.GN3845@adacore.com> (raw)
In-Reply-To: <20100919173918.GA29737@host1.dyn.jankratochvil.net>

> For add_partial_symbol - why do you make DW_TAG_constant different from
> DW_TAG_variable?  DW_TAG_variable would handle more cases there.

As explained in my original email - I felt at the time that this would
make the DW_TAG_variable case overly complicated, whereas I did not see
why DW_TAG_constant would need more than what I added. If we prefer to
merge the two, I'm happy too. I just wanted to help keep things as
simple as possible.  What do you think?

I'm sorry about the two blunders last week. The consequence of trying
to do too much at the same time while trying to get ready for yet
another trip. I'm back, now, so I will try to focus a little better.

-- 
Joel


  reply	other threads:[~2010-09-20 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16 21:31 Joel Brobecker
2010-09-16 22:23 ` Nathan Froyd
2010-09-16 22:29   ` Joel Brobecker
2010-09-17 13:11     ` Pedro Alves
2010-09-19 23:02 ` Jan Kratochvil
2010-09-21 18:41   ` Joel Brobecker [this message]
2010-09-21 19:43     ` Jan Kratochvil
2010-09-22 18:43       ` Joel Brobecker
2010-09-22 19:42         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100920160844.GN3845@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox