From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2493 invoked by alias); 12 Sep 2010 13:31:23 -0000 Received: (qmail 2485 invoked by uid 22791); 12 Sep 2010 13:31:22 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Sep 2010 13:31:18 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8CDVGuW020041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 12 Sep 2010 09:31:16 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8CDVEjO031697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 12 Sep 2010 09:31:15 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o8CDVDYl021616 for ; Sun, 12 Sep 2010 15:31:13 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o8CDVDDC021615 for gdb-patches@sourceware.org; Sun, 12 Sep 2010 15:31:13 +0200 Date: Mon, 13 Sep 2010 08:28:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] testsuite: sigall.exp: Fix false FAILs Message-ID: <20100912133113.GA21299@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00242.txt.bz2 Hi, if your sourcetree topdir contains a substring "kill" then while still: make check RUNTESTFLAGS=gdb.base/sigall.exp # of expected passes 380 the other case starts FAILing: make check//unix RUNTESTFLAGS=gdb.base/sigall.exp # of expected passes 290 # of unexpected failures 90 It is due to a false catch in the second case: Breakpoint 61, gen_WAITING () at /home/jkratoch/redhat/gdb-test-dir-kill/gdb/testsuite/gdb.base/sigall.c:1136^M 1136 handle_WAITING (0);^M which is not a problem in the first case: Breakpoint 61, gen_WAITING () at ./gdb.base/sigall.c:1136^M 1136 handle_WAITING (0);^M The two lines being matched look always like: 826 kill (getpid (), SIGILL);^M 839 handle_EMT (0);^M Tested on x86_64-fedora14snapshot-linux-gnu. Going to check it in in some days as obvious. Thanks, Jan gdb/testsuite/ 2010-09-12 Jan Kratochvil Fix false FAILs on sourcetree topdir directory containing "kill". * gdb.base/sigall.exp (test_one_sig) : Extend the source line matching regexp. --- a/gdb/testsuite/gdb.base/sigall.exp +++ b/gdb/testsuite/gdb.base/sigall.exp @@ -94,11 +94,11 @@ proc test_one_sig {nextsig} { if { $missed_handler == "0" } then { gdb_test_multiple "signal 0" "advance to $nextsig" { - -re "Breakpoint.*gen_$nextsig.*kill.*$gdb_prompt $" { + -re "Breakpoint.*gen_$nextsig.*\r\n\[0-9\]+\[ \t\]+kill \\(.*\r\n$gdb_prompt $" { pass "advance to $nextsig" set sig_supported 1 } - -re "Breakpoint.*gen_$nextsig.*handle.*$gdb_prompt $" { + -re "Breakpoint.*gen_$nextsig.*\r\n\[0-9\]+\[ \t\]+handle_.*\r\n$gdb_prompt $" { pass "advance to $nextsig" set sig_supported 0 }