Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix ELF stale reference [Re: [patch] .gdb_index: Do not crash on NOBITS]
Date: Thu, 09 Sep 2010 16:11:00 -0000	[thread overview]
Message-ID: <20100909145615.GA5771@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <AANLkTikm4c_dPTiqA8hsw8AkNbpKbyQNxC3qgRJi98Au@mail.gmail.com>

On Thu, 09 Sep 2010 16:51:51 +0200, Doug Evans wrote:
> On Thu, Sep 9, 2010 at 2:05 AM, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> > --- a/gdb/elfread.c
> > +++ b/gdb/elfread.c
> > @@ -37,6 +37,7 @@
> > +#include "libbfd.h"
> 
> Apologies for nitpicking but this raises an issue I'd like to understand better.
> I thought libbfd.h was an internal bfd header.
> [I know I've wanted to use it at least once and been told "No." :-)]

I have seen

amd64-darwin-tdep.c:#include "libbfd.h"
i386-darwin-tdep.c:#include "libbfd.h"
rs6000-nat.c:#include "libbfd.h"		/* For bfd_default_set_arch_mach (FIXME) */
rs6000-tdep.c:#include "libbfd.h"		/* for bfd_default_set_arch_mach */

so I considered it legal.

OTOH this patch is not completely clean, it can needlessly allocate
bfd-associated memory and the right fix would probably span into bfd/ IMO.


Thanks,
Jan


  reply	other threads:[~2010-09-09 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 19:40 [patch] .gdb_index: Do not crash on NOBITS Jan Kratochvil
2010-09-08 23:19 ` Tom Tromey
2010-09-08 23:36   ` Jan Kratochvil
2010-09-09 14:05   ` [patch] Fix ELF stale reference [Re: [patch] .gdb_index: Do not crash on NOBITS] Jan Kratochvil
2010-09-09 16:01     ` Doug Evans
2010-09-09 16:11       ` Jan Kratochvil [this message]
2010-10-14 16:07         ` [patch] Fix ELF stale reference Jan Kratochvil
2010-10-14 17:46           ` Tom Tromey
2010-11-19 22:49             ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100909145615.GA5771@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox