From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75450-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1137 invoked by alias); 6 Sep 2010 00:29:32 -0000
Received: (qmail 1129 invoked by uid 22791); 6 Sep 2010 00:29:31 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Sep 2010 00:29:27 +0000
Received: (qmail 689 invoked from network); 6 Sep 2010 00:29:25 -0000
Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 6 Sep 2010 00:29:25 -0000
Date: Mon, 06 Sep 2010 09:46:00 -0000
From: Daniel Jacobowitz <dan@codesourcery.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: Doug Evans <dje@google.com>, Tom Tromey <tromey@redhat.com>,	gdb-patches@sourceware.org
Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache]
Message-ID: <20100906002915.GA20920@caradoc.them.org>
Mail-Followup-To: sami wagiaalla <swagiaal@redhat.com>,	Doug Evans <dje@google.com>, Tom Tromey <tromey@redhat.com>,	gdb-patches@sourceware.org
References: <AANLkTiktKEH04642oBgKC1LJO2jwp4zF4941Z6L3dM3H@mail.gmail.com> <m3y6blb98k.fsf@fleche.redhat.com> <4C7EA30B.7020007@redhat.com> <AANLkTimsOWkmm-n08E5d-kZNDvjhmhzNZ65w1cxTiffq@mail.gmail.com> <4C7EA94E.4010104@redhat.com> <AANLkTimB6uPbPQOLY-0SFeG_Zfo0Ea1V1Xr0mj-j3cTB@mail.gmail.com> <4C7FC495.8090705@redhat.com> <AANLkTikygL12Pn2meq5MexcntkbYv2bBotbQMstR7QWz@mail.gmail.com> <AANLkTi=KwykoGq4tYSTgZybuw7ffp0Md6oOBNN4=87NL@mail.gmail.com> <4C81547B.3010603@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C81547B.3010603@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00145.txt.bz2

On Fri, Sep 03, 2010 at 04:03:07PM -0400, sami wagiaalla wrote:
> 
> >Blech.  "never mind".  We do need the memset.
> >The hash still includes sizeof (ginfo.value), which is reasonable (I
> >thought it didn't for some reason).
> >gcc turns it in to a move instruction anyway so no worries there.
> 
> Alright, the attached patch memsets value and initializes obj_section
> as you suggested. Is this ok to commit ?

This works for me; I think it's OK to commit.


-- 
Daniel Jacobowitz
CodeSourcery