From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14292 invoked by alias); 31 Aug 2010 18:12:27 -0000 Received: (qmail 14279 invoked by uid 22791); 31 Aug 2010 18:12:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 18:12:22 +0000 Received: (qmail 23901 invoked from network); 31 Aug 2010 18:12:18 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Aug 2010 18:12:18 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] Code cleanup: Make function typedef for find memory region Date: Tue, 31 Aug 2010 18:12:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <20100830085953.GA25961@host1.dyn.jankratochvil.net> <201008301143.55582.pedro@codesourcery.com> <20100831172720.GA27390@host1.dyn.jankratochvil.net> In-Reply-To: <20100831172720.GA27390@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008311912.15228.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00558.txt.bz2 On Tuesday 31 August 2010 18:27:21, Jan Kratochvil wrote: > On Mon, 30 Aug 2010 12:43:55 +0200, Pedro Alves wrote: > > I suggest you don't use _t for this. Most of our function typedefs > > use the *_ftype prefix, a few _func, and only a couple _fn or _t. > [...] > > find_memory_region_ftype > > Chose this one. Thanks. This looks fine to me. -- Pedro Alves