From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29902 invoked by alias); 31 Aug 2010 18:45:52 -0000 Received: (qmail 29889 invoked by uid 22791); 31 Aug 2010 18:45:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 18:45:45 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o7VIix0N016870; Tue, 31 Aug 2010 20:44:59 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o7VIivPI017714; Tue, 31 Aug 2010 20:44:57 +0200 (CEST) Date: Tue, 31 Aug 2010 18:45:00 -0000 Message-Id: <201008311844.o7VIivPI017714@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: jan.kratochvil@redhat.com CC: brobecker@adacore.com, eliz@gnu.org, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org In-reply-to: <20100831182829.GA16136@host1.dyn.jankratochvil.net> (message from Jan Kratochvil on Tue, 31 Aug 2010 20:28:29 +0200) Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t References: <20100831182829.GA16136@host1.dyn.jankratochvil.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00565.txt.bz2 > Date: Tue, 31 Aug 2010 20:28:29 +0200 > From: Jan Kratochvil > > On Mon, 30 Aug 2010 16:08:14 +0200, Joel Brobecker wrote: > > It does not matter much to me if we decide to allow types named with > > a _t suffix. But the gdb_ prefix also increases the chances of avoiding > > name collisions with external declarations. > > On Mon, 30 Aug 2010 16:11:45 +0200, Eli Zaretskii wrote: > > A strange ruling, I think _t is used in lots of applications. > > I would prefer gdb_target_signal_t or also gdb_target_signal. > > Is one of those approved? If you're going to change it, I vote for gdb_target_signal. I won't block target_signal_t either, but I do hope people realize the _t suffix should be avoided, or at least an app-specific prefix should be used. Cheers, Mark