Re: [patch] Code cleanup: Make function typedef for find memory region

Jan Kratochvil
2010-08-30T14:25:42Z

On Mon, 30 Aug 2010 16:14:54 +0200, Joel Brobecker wrote:
> I also believe that we should explicitly name the parameters in the
> function type declaration.

I try to do that whenever I can, I am for making it a part of patch reviews.

When we are at the rules:

I am also for requiring comment to be placed at the function definition and
not at its declaration. Using tag jumps one will never find the declaration
and I have considered these functions to have no comment (randomly found now
simple_displaced_step_copy_insn, it was a different function I had the problem
with).

I am also for forbidding putting comments there at both places as such way
they get inconsistent soon or they differ etc. (randomly found init_type).

Regards,
Jan