From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27166 invoked by alias); 31 Aug 2010 17:13:00 -0000 Received: (qmail 27151 invoked by uid 22791); 31 Aug 2010 17:12:59 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 17:12:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 60FBE2BABBF; Tue, 31 Aug 2010 13:12:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Bo293qDc2njk; Tue, 31 Aug 2010 13:12:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2AE622BAB5A; Tue, 31 Aug 2010 13:12:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8CE05F599F; Tue, 31 Aug 2010 19:12:45 +0200 (CEST) Date: Tue, 31 Aug 2010 17:13:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: Make function typedef for find memory region Message-ID: <20100831171245.GK2986@adacore.com> References: <20100830085953.GA25961@host1.dyn.jankratochvil.net> <20100830141454.GG2986@adacore.com> <20100830142507.GA1356@host1.dyn.jankratochvil.net> <20100831130152.GB9173@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00552.txt.bz2 > Jan> Implementation should name the field in the interface to be able to jump > Jan> there. > > I like this idea. The documentation I write in that case is: /* Implement the to_do_this target_ops method. */ This avoid duplication, and refers back to the routine that this function is supposed to implement. -- Joel