From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25442 invoked by alias); 30 Aug 2010 20:11:30 -0000 Received: (qmail 25433 invoked by uid 22791); 30 Aug 2010 20:11:28 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 20:11:23 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7UKBE4b023400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Aug 2010 16:11:14 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7UKBCDm030712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 Aug 2010 16:11:13 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7UKBB8b025103; Mon, 30 Aug 2010 22:11:11 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7UKBA7g025102; Mon, 30 Aug 2010 22:11:10 +0200 Date: Mon, 30 Aug 2010 20:11:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [0/9]#2 Fix lost siginfo_t Message-ID: <20100830201110.GA17151@host1.dyn.jankratochvil.net> References: <20100830070955.GA6831@host1.dyn.jankratochvil.net> <201008302050.02945.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008302050.02945.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00534.txt.bz2 On Mon, 30 Aug 2010 21:50:02 +0200, Pedro Alves wrote: > I must confess that my knee-jerk reaction to the main idea > of the patchset is "I'm not convinced this is a good idea". > A thread can't be stopped for more than one reason at the > same time, so why isn't target_wait plus an on-the-side > interface to get at the expensive-to-get siginfo enough? Because linux-nat.c internals stop it on a different signal (SIGSTOP one) than the interestign one (e.g. SIGUSR1) for which GDB was stopping. > and ran the test against amd64-linux gdbserver: I can confirm FSF gdbserver also works for me with gdb.threads/siginfo-threads.exp . The testcase also correctly SIGSTOPs its getppid(), therefore gdbserver, which is the right target for the testcase. > I'm guessing that this is because of gdbserver/linux-low.c's > much better handling of pending signals than linux-nat.c's. > (see linux-low.c's lwp->pending_signals, and linux_resume_one_lwp, > for example). I had to fix linux-nat.c for backport reasons anyway but I probably could keep it only internal (and hack it more dirty without the FSF import intention). I see I went needlessly far. I am not sure how much interest is in pusing it for FSF linux-nat.c . I made it more as a proof of concept before I start fixing gdb/remote.c (for ugdb). I did not expect gdb/remote.c needs no changes at all. I still have not seen any FSF general future development direction, linux-nat.c is IMO obsolete already, at least due to FSF gdbserver. OK to post some patches to run in remote mode during default "run" etc. commands? Thanks, Jan