Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

Jan Kratochvil
2010-09-01T18:45:16Z

On Wed, 01 Sep 2010 20:38:01 +0200, Pedro Alves wrote:
> Weren't you proposing to end up with something like
> "typedef struct target_signal target_signal"?
>
> Then you'd do "s/enum target_signal/target_signal/g" , which is
> shorter.

I have never proposed "target_signal" to be a type as I find it a possible
parameter/variable name; although it is not in use now:
grep -rP '(?<!enum )target_signal\b' .

> But, if you guys want to rename the type, I won't stand in the way,
> thought I'd suggest simply gdb_signal. One of "gdb or "target" in
> "gdb_target" appears redundant to me.

Removing the misleading "target" word would be great, "gdb_target" even
suggests it is an in-GDB signal type, not a target-encoded signal type.

Thanks,
Jan