Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

Joel Brobecker
2010-09-01T18:18:46Z

> I would prefer gdb_target_signal_t or also gdb_target_signal.
>
> Is one of those approved?

I've just realize that this specific patch really only renames
the type, in addition to adding a typedef.

I'm just wondering why this is actually useful to you. I would have
thought that we could avoid this patch entirely, and then let the
next patch which introduces the gdb_target_signal as a struct just
update all uses of the enum type. Once the struct has been introduced,
we could do a rename if we feel that a better name of the enum can
be found - I think that doing the rename would produce a patch
that is smaller if done after introducing the struct wrapper first.

Just some thoughts...

--
Joel