Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

Mark Kettenis
2010-08-30T08:14:37Z

> Date: Mon, 30 Aug 2010 09:10:40 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> series #2 of: http://sourceware.org/ml/gdb-patches/2010-07/msg00408.html
>
> Hi,
>
> there is no compiled code change in this patch. This patch just renames `enum
> target_signal' to target_signal_t (typedef) so the code is more flexible for
> the later changes. No other change is made.

The _t suffix is actually reserved by POSIX, so using it is actually a
bad idea. Perhaps change it to gdb_target_signal, or just
target_signal (making it a typedef for an anonymous enum)?