Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

Jan Kratochvil
2010-09-02T15:48:48Z

On Thu, 02 Sep 2010 17:39:23 +0200, Joel Brobecker wrote:
> > struct target_signal_o
> > {
> > int number;
> > const char *name;
> > const char *string;
> > };
[...]
> And I don't think that this is incompatible with Jan's initial goal
> of having a structure with signal and siginfo data.

It is currently incompatible as to keep it <= / >= etc. comparable it must be
kept as a pointer-to-struct, not as a struct-as-value. This approach expects
there is a finite set of predefined target_signal possibilities.

But then arbitrary set of dynamic content requires some allocate/free and/or
ref/unref. Marking all reffing/unreffing in the code is according to my
experience unmanageable.

> but if we ever change our mind again,

one day in the future GDB may already have C++ and everything will be easy.

Thanks,
Jan