From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20801 invoked by alias); 27 Aug 2010 00:19:33 -0000 Received: (qmail 20790 invoked by uid 22791); 27 Aug 2010 00:19:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Aug 2010 00:19:26 +0000 Received: (qmail 22802 invoked from network); 27 Aug 2010 00:19:25 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Aug 2010 00:19:25 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [commit] [gdbserver/linux] access memory of running processes Date: Fri, 27 Aug 2010 00:19:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <201008270026.22929.pedro@codesourcery.com> <201008270102.43464.pedro@codesourcery.com> <4C77010C.60607@vmware.com> In-Reply-To: <4C77010C.60607@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008270119.24050.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00456.txt.bz2 On Friday 27 August 2010 01:04:28, Michael Snyder wrote: > Pedro Alves wrote: > > On Friday 27 August 2010 00:28:56, Michael Snyder wrote: > >> Hmmm, don't like "unprepare_to_access_memory". > >> > >> What about "finish_accessing_memory"? > > > > Hmm, I don't like "finish", since the access has finished > > already when we call this function. How about "done_accessing_memory"? > > Done is good. So done. > > Any other suggestions/nits? :-) > > Yeah! I don't like "Pedro". Why don't you change it to "Pecos Pete"? > ;-) Sure, done. :-) Just don't ask me about the West. -- Pecos Pete 2010-08-27 Pedro Alves * linux-low.c (linux_unprepare_to_access_memory): Rename to ... (linux_done_accessing_memory): ... this. (linux_target_ops): Adjust. * linux-x86-low.c (x86_insert_point, x86_remove_point): Adjust. * nto-low.c (nto_target_ops): Adjust comment. * server.c (gdb_read_memory, gdb_write_memory): Adjust. * spu-low.c (spu_target_ops): Adjust comment. * target.h (target_ops): Rename unprepare_to_access_memory field to done_accessing_memory. (unprepare_to_access_memory): Rename to ... (done_accessing_memory): ... this. --- gdb/gdbserver/linux-low.c | 4 ++-- gdb/gdbserver/linux-x86-low.c | 4 ++-- gdb/gdbserver/nto-low.c | 2 +- gdb/gdbserver/server.c | 4 ++-- gdb/gdbserver/spu-low.c | 2 +- gdb/gdbserver/target.h | 8 ++++---- gdb/gdbserver/win32-low.c | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) Index: src/gdb/gdbserver/linux-low.c =================================================================== --- src.orig/gdb/gdbserver/linux-low.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/linux-low.c 2010-08-27 01:08:48.000000000 +0100 @@ -5016,7 +5016,7 @@ linux_prepare_to_access_memory (void) } static void -linux_unprepare_to_access_memory (void) +linux_done_accessing_memory (void) { /* Neither ptrace nor /proc/PID/mem allow accessing memory through a running LWP. */ @@ -5063,7 +5063,7 @@ static struct target_ops linux_target_op linux_fetch_registers, linux_store_registers, linux_prepare_to_access_memory, - linux_unprepare_to_access_memory, + linux_done_accessing_memory, linux_read_memory, linux_write_memory, linux_look_up_symbols, Index: src/gdb/gdbserver/linux-x86-low.c =================================================================== --- src.orig/gdb/gdbserver/linux-x86-low.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/linux-x86-low.c 2010-08-27 01:12:50.000000000 +0100 @@ -562,7 +562,7 @@ x86_insert_point (char type, CORE_ADDR a if (ret) return -1; ret = set_gdb_breakpoint_at (addr); - unprepare_to_access_memory (); + done_accessing_memory (); return ret; } case '2': @@ -590,7 +590,7 @@ x86_remove_point (char type, CORE_ADDR a if (ret) return -1; ret = delete_gdb_breakpoint_at (addr); - unprepare_to_access_memory (); + done_accessing_memory (); return ret; } case '2': Index: src/gdb/gdbserver/nto-low.c =================================================================== --- src.orig/gdb/gdbserver/nto-low.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/nto-low.c 2010-08-27 01:10:15.000000000 +0100 @@ -914,7 +914,7 @@ static struct target_ops nto_target_ops nto_fetch_registers, nto_store_registers, NULL, /* prepare_to_access_memory */ - NULL, /* unprepare_to_access_memory */ + NULL, /* done_accessing_memory */ nto_read_memory, nto_write_memory, NULL, /* nto_look_up_symbols */ Index: src/gdb/gdbserver/server.c =================================================================== --- src.orig/gdb/gdbserver/server.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/server.c 2010-08-27 01:10:41.000000000 +0100 @@ -564,7 +564,7 @@ gdb_read_memory (CORE_ADDR memaddr, unsi if (ret == 0) { ret = read_inferior_memory (memaddr, myaddr, len); - unprepare_to_access_memory (); + done_accessing_memory (); } return ret; @@ -586,7 +586,7 @@ gdb_write_memory (CORE_ADDR memaddr, con if (ret == 0) { ret = write_inferior_memory (memaddr, myaddr, len); - unprepare_to_access_memory (); + done_accessing_memory (); } return ret; } Index: src/gdb/gdbserver/spu-low.c =================================================================== --- src.orig/gdb/gdbserver/spu-low.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/spu-low.c 2010-08-27 01:10:55.000000000 +0100 @@ -654,7 +654,7 @@ static struct target_ops spu_target_ops spu_fetch_registers, spu_store_registers, NULL, /* prepare_to_access_memory */ - NULL, /* unprepare_to_access_memory */ + NULL, /* done_accessing_memory */ spu_read_memory, spu_write_memory, spu_look_up_symbols, Index: src/gdb/gdbserver/target.h =================================================================== --- src.orig/gdb/gdbserver/target.h 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/target.h 2010-08-27 01:11:25.000000000 +0100 @@ -196,7 +196,7 @@ struct target_ops /* Undo the effects of prepare_to_access_memory. */ - void (*unprepare_to_access_memory) (void); + void (*done_accessing_memory) (void); /* Read memory from the inferior process. This should generally be called through read_inferior_memory, which handles breakpoint shadowing. @@ -491,11 +491,11 @@ ptid_t mywait (ptid_t ptid, struct targe ? (*the_target->prepare_to_access_memory) () \ : 0) -#define unprepare_to_access_memory() \ +#define done_accessing_memory() \ do \ { \ - if (the_target->unprepare_to_access_memory) \ - (*the_target->unprepare_to_access_memory) (); \ + if (the_target->done_accessing_memory) \ + (*the_target->done_accessing_memory) (); \ } while (0) int read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len); Index: src/gdb/gdbserver/win32-low.c =================================================================== --- src.orig/gdb/gdbserver/win32-low.c 2010-08-27 00:15:01.000000000 +0100 +++ src/gdb/gdbserver/win32-low.c 2010-08-27 01:12:12.000000000 +0100 @@ -1782,7 +1782,7 @@ static struct target_ops win32_target_op win32_fetch_inferior_registers, win32_store_inferior_registers, NULL, /* prepare_to_access_memory */ - NULL, /* unprepare_to_access_memory */ + NULL, /* done_accessing_memory */ win32_read_inferior_memory, win32_write_inferior_memory, NULL, /* lookup_symbols */