On Tue, Aug 24, 2010 at 10:12:57AM -0400, Daniel Jacobowitz wrote:
> On Tue, Aug 24, 2010 at 01:27:03PM +0200, Mark Kettenis wrote:
> > > Date: Mon, 23 Aug 2010 23:38:54 -0700
> > > From: Yao Qi <yao@codesourcery.com>
> > > 
> > > Hi,
> > > This patch is to calculate correct address of 'next pc' of syscall
> > > sigreturn and rt_sigreturn.
> > 
> > You're polluting the genric arm code with Linux-specific stuff.
> > Please don't do that.  If something like this is needed, it should be
> > added to code in arm-linux-tdep.c.
> 
> There's a couple of ways to do that; one example is
> mips_linux_syscall_next_pc.

Here is the updated patch, in which:
  1.  Add arm_linux_syscall_next_pc, similar to
mips_linux_syscall_next_pc.  Compute the return address of SWI in both
ARM mode and Thumb mode.
  2.  Extract some common code from arm_linux_copy_svc.

Tested on armv7l-unknown-linux-gnueabi again.  Result is the same as
my previous post.

-- 
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739