Re: Your INTERMEDIATE_ENCODING patch for Solaris

Tom Tromey
2010-09-16T18:30:52Z

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Tom> Great. Here is what I am checking in.

Pierre> Nice, but I was wondering if the
Pierre> check of libiconv version is still needed.
Pierre> Wasn't it suggested by me?

According to the comment, versions of libiconv before 0x10D do not
support "wchar_t" as an argument to iconv_open.

I think you discovered this, but it is hard to remember.

Pierre> I think that checking for the existence of
Pierre> _LIBICONV_VERSION macro should be enough,
Pierre> unless you are really sure that older versions
Pierre> do not work.
Pierre> On systems that have an older GNU libiconv
Pierre> version installed, this might disable the use of GNU libiconv
Pierre> without a good reason.

I think it is better to fail safe:
If this code is disabled, the user gets reduced functionality.
If this code is erroneously enabled, users can't print strings at all.

Tom