RE: Your INTERMEDIATE_ENCODING patch for Solaris

Pierre Muller
2010-09-23T07:19:53Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Wednesday, September 22, 2010 10:57 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: Your INTERMEDIATE_ENCODING patch for Solaris
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
>
> Pierre> I found the libiconv version 1.5
> Pierre> installed it on a x86 Open Solaris machine,
> Pierre> modified gdb_wchar.h to use _LIBICONV_VERSION >= 0x105
> Pierre> and got an gdb executable linked to libiconv version 1.5,
> Pierre> using --with-libiconv-prefix=/usr/local/src/test32
> Pierre> (the installation prefix I used for 1.5 libiconv).
> Pierre> I tested charset.exp result on that executable,
> Pierre> and got a lot of failures:
> [...]
>
> Pierre> But I was wondering if the problem is not coming from the
> Pierre> fact that for 1.5 libiconv find_charset_names function
> Pierre> directly calls 'iconv -l' (because iconvlist is not present
> Pierre> in this version of the library).
>
> Ouch.
>
> Pierre> I also downloaded version 1.8 of libiconv,
> Pierre> and checked GDB linked to that version:
> Pierre> the results of charset.exp are the same as 1.13.1 (2 FAILs)
>
> Yeah, how about we make x0108 the minimal acceptable version?
> It was released in 2002, that seems plenty old to me.
>
> If you agree, I will make the change.

I agree, furthermore HAVE_LIBICONVLIST
should always be set in config.h in that case,
which avoids the direct call to 'iconv -l'.

> Pierre> PS: Support of libc iconv for Solaris could probably be
> Pierre> enhanced by a better parsing of 'iconv -l' output...
>
> I think there isn't much reason to do it, since we're planning to avoid
> Solaris iconv completely. If somebody wants to make the effort,
> though,
> it is fine by me.

Not sure I will have time for that...

Pierre