Re: Your INTERMEDIATE_ENCODING patch for Solaris

Tom Tromey
2010-09-02T15:36:32Z

Pierre> Probably just define PHONY_ICONV if the first set of conditions is
Pierre> not met (by the way, I am not sure the libiconv version test
Pierre> that we added is really pertinent.)

Thanks. I think I got the logic wrong:

+/* If we got here and have wchar_t support, we might be on a system
+ with some problem. So, we just disable everything. */
+#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC))
+#define PHONY_ICONV
+#endif

I think that "!" is wrong -- it even contradicts the comment.
I'm sorry to keep bothering you about this, but could you remove that
"!" and try again?

Tom