Re: Your INTERMEDIATE_ENCODING patch for Solaris

Tom Tromey
2010-09-14T20:56:56Z

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Pierre> Probably just define PHONY_ICONV if the first set of conditions is
Pierre> not met (by the way, I am not sure the libiconv version test
Pierre> that we added is really pertinent.)

Tom> Thanks. I think I got the logic wrong:

Tom> +/* If we got here and have wchar_t support, we might be on a system
Tom> + with some problem. So, we just disable everything. */
Tom> +#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC))
Tom> +#define PHONY_ICONV
Tom> +#endif

Tom> I think that "!" is wrong -- it even contradicts the comment.
Tom> I'm sorry to keep bothering you about this, but could you remove that
Tom> "!" and try again?

Any word on this?
I would like to commit this patch if it seems ok.

Tom