RE: Your INTERMEDIATE_ENCODING patch for Solaris

Pierre Muller
2010-09-16T07:55:23Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Wednesday, September 15, 2010 10:18 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: Your INTERMEDIATE_ENCODING patch for Solaris
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
>
> Pierre> I can at least confirm that for
> Pierre> Sparc OpenSolaris 5.11 snv_111b it does
> Pierre> disable use of iconv functions from libc.so.1
>
> Pierre> So, at least for me, this should be modified
> Pierre> that way.
>
> Great. Here is what I am checking in.

Nice, but I was wondering if the
check of libiconv version is still needed.
Wasn't it suggested by me?
I think that checking for the existence of
_LIBICONV_VERSION macro should be enough,
unless you are really sure that older versions
do not work.
On systems that have an older GNU libiconv
version installed, this might disable the use of GNU libiconv
without a good reason.

Pierre