From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32416 invoked by alias); 16 Aug 2010 18:19:44 -0000 Received: (qmail 32408 invoked by uid 22791); 16 Aug 2010 18:19:43 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Aug 2010 18:19:34 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o7GII8eG010019; Mon, 16 Aug 2010 20:18:08 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o7GII777014877; Mon, 16 Aug 2010 20:18:07 +0200 (CEST) Date: Mon, 16 Aug 2010 18:19:00 -0000 Message-Id: <201008161818.o7GII777014877@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: yao@codesourcery.com CC: gdb-patches@sourceware.org In-reply-to: <20100816153920.GA20732@qiyaows> Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb References: <20100812081814.GA24769@qiyaows> <201008120935.o7C9Zpid015638@glazunov.sibelius.xs4all.nl> <20100812114907.GB24769@qiyaows> <20100812123437.GA31629@caradoc.them.org> <20100812132153.GC24769@qiyaows> <20100813132811.GA20656@caradoc.them.org> <20100816153920.GA20732@qiyaows> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00229.txt.bz2 > Date: Mon, 16 Aug 2010 23:39:21 +0800 > From: "Yao Qi" > > > > > > > > > Can you use func_loopfb instead of func_loopfb_start in the .S file? > > > > Or, can you define func_loopfb_start as asm ("func_loopfb_start = > > > > func_loopfb")? > > > > > > > > A third option is to address Mark's concern by using ".p2align 4"; I > > > > believe that is 16-byte alignment on all platforms gas supports, and > > > > this test probably requires gas in practice already. > > > > > > Yeah, update my patch by replacing '.align 2' with '.p2align 4'. > > > Is that OK? > > > > Looks fine to me. Mark, what do you think? > > Mark, > Is this patch OK to you? Sorry, I though I replied to Daniel's message. Anyway, I'm afraid I don't understand the problem you're trying to fix, so it's hard to say for me that the diff is ok. However, I'd say that 32-bit alignment should be enough; I don't know any architectures that have instructions longer than 32-bits and care about alignment.