From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74889-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16604 invoked by alias); 12 Aug 2010 09:38:36 -0000
Received: (qmail 16591 invoked by uid 22791); 12 Aug 2010 09:38:36 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Aug 2010 09:38:31 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o7C9ZrbN032763;	Thu, 12 Aug 2010 11:35:53 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o7C9Zpid015638;	Thu, 12 Aug 2010 11:35:51 +0200 (CEST)
Date: Thu, 12 Aug 2010 09:38:00 -0000
Message-Id: <201008120935.o7C9Zpid015638@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
CC: gdb-patches@sourceware.org
In-reply-to: <20100812081814.GA24769@qiyaows> (message from Yao Qi on Thu, 12	Aug 2010 16:18:14 +0800)
Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb
References:  <20100812081814.GA24769@qiyaows>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00171.txt.bz2

> Date: Thu, 12 Aug 2010 16:18:14 +0800
> From: Yao Qi <yao@codesourcery.com>
> Content-Disposition: inline
> 
> We find test failures in gdb.dwarf2/dw2-ref-missing-frame.exp when
> test cases are compiled as thumb.
> https://bugs.launchpad.net/gdb-linaro/+bug/615997
> 
> In dw2-ref-missing-frame-func.c, it is assumed that address of label
> 'func_loopfb_start' is equal to address of function func_loopfb.
> However, in thumb, the label is 16-bit aligned, while function is
> 32-bit aligned, so label address may not be equal to function address.
> 
> Patch below is to set labels 32-bit aligned.  Tested this patch on
> both x86 and armel.  OK to apply?

Unfortunately not.  The .align pseudo-op has different effects on
different architectures.  On most architectures .align 2 actually
means 16-bit alignment, which is certainly not what you want on RISC
architectures that have 32-bit wide instructions.