From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14951 invoked by alias); 31 Jul 2010 08:03:06 -0000 Received: (qmail 14741 invoked by uid 22791); 31 Jul 2010 08:03:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 31 Jul 2010 08:03:00 +0000 Received: (qmail 19050 invoked from network); 31 Jul 2010 08:02:59 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Jul 2010 08:02:59 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch 2/6] Merge target_signal definitions to one place Date: Sat, 31 Jul 2010 08:03:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-24-generic; KDE/4.4.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <20100726225113.GC3597@host1.dyn.jankratochvil.net> <201007310023.22210.pedro@codesourcery.com> <20100731042223.GA29843@host1.dyn.jankratochvil.net> In-Reply-To: <20100731042223.GA29843@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007310902.55210.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00605.txt.bz2 On Saturday 31 July 2010 05:22:23, Jan Kratochvil wrote: > On Sat, 31 Jul 2010 01:23:21 +0200, Pedro Alves wrote: > > Thanks. In that case, you should also update the server.o rule, which > > depends on server.c, which now depends on signals.def. > > And I missed its dependency on signals.h having dependency signals.def is not > enough wrt future changes, OK. > I am very sorry, I meant signals.o -> signals.c -> signals.def, not server.*. :-/ I don't know why I wrote server.o,server.c. :-( server.c's dependency is always through signals.h, which is included by server.h, and $(server_h) is depending on server.def, so that was fine. It's signals.c that has a direct include of signals.def. Mainly a pedantic correctness issue, since signals.c is depending on signals.h... I've applied the patch below. -- Pedro Alves 2010-07-31 Pedro Alves * Makefile.in (signals_h): New. (server_h): Depend on it. (server.o): Don't depend on $(signals_def). (signals.o): Depend on $(signals_def). --- gdb/gdbserver/Makefile.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) Index: src/gdb/gdbserver/Makefile.in =================================================================== --- src.orig/gdb/gdbserver/Makefile.in 2010-07-31 08:40:49.000000000 +0100 +++ src/gdb/gdbserver/Makefile.in 2010-07-31 08:53:16.000000000 +0100 @@ -293,9 +293,10 @@ regdat_sh = $(srcdir)/../regformats/regd regdef_h = $(srcdir)/../regformats/regdef.h regcache_h = $(srcdir)/regcache.h signals_def = $(srcdir)/../../include/gdb/signals.def +signals_h = $(srcdir)/../../include/gdb/signals.h $(signals_def) server_h = $(srcdir)/server.h $(regcache_h) config.h $(srcdir)/target.h \ $(srcdir)/mem-break.h $(srcdir)/../common/gdb_signals.h \ - $(srcdir)/../../include/gdb/signals.h $(signals_def) + $(signals_h) linux_low_h = $(srcdir)/linux-low.h @@ -335,14 +336,14 @@ mem-break.o: mem-break.c $(server_h) proc-service.o: proc-service.c $(server_h) $(gdb_proc_service_h) regcache.o: regcache.c $(server_h) $(regdef_h) remote-utils.o: remote-utils.c terminal.h $(server_h) -server.o: server.c $(server_h) $(signals_def) +server.o: server.c $(server_h) target.o: target.c $(server_h) thread-db.o: thread-db.c $(server_h) $(linux_low_h) $(gdb_proc_service_h) tracepoint.o: tracepoint.c $(server_h) utils.o: utils.c $(server_h) gdbreplay.o: gdbreplay.c config.h -signals.o: ../common/signals.c $(server_h) +signals.o: ../common/signals.c $(server_h) $(signals_def) $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER memmem.o: ../gnulib/memmem.c