Re: [patch] Add solib_address and decode_line Python functionality

Tom Tromey
2010-08-06T22:39:21Z

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I looked at the documentation and PY_LONG_LONG is only available on
Phil> some platforms (namely, 64 bit platforms). I used unsigned long, and
Phil> 'k' instead.

I think PY_LONG_LONG should be available in other situations too -- in
particular if the compiler supports "long long", which GCC does.

It is important to use PY_LONG_LONG if it is available. E.g., consider
if gdb is hosted on a 32-bit machine but debugging a 64-bit executable.
In this case an address will be 64 bits.

So, could you make this conditional?

The rest looks good to me.

Tom