Re: [patch] Add solib_address and decode_line Python functionality

Phil Muldoon
2010-08-13T14:14:47Z

On 13/08/10 15:07, Ken Werner wrote:
> On Tuesday, August 10, 2010 08:24:09 pm Tom Tromey wrote:
>>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>> Tom> So, could you make this conditional?
>>
>> Phil> Sure, what do you think of the attached patch?
>>
>> Thanks for persevering. This is ok.
>
> Hi,
>
> It looks like the const qualifier of the format string argument of the
> PyArg_Parse* routines has been introduced after the Python 2.4 release:
> http://svn.python.org/view?view=rev&revision=41638
> In case gdb is built against libpython 2.4 the current code would generate a
> warning. One solution would be to just remove the const qualifier. A small
> patch is attached. Any comments are appreciated.

Thanks for catching this. It looks fine to me; but wait for Tom or
another maintainer to give the official nod first.

Cheers

Phil