Re: [patch] Add solib_address and decode_line Python functionality

Joel Brobecker
2010-07-27T16:26:01Z

Just my 2 cents on the API and doc...

> solib_address -- lookup an address and if it resides in an solib
> reports that libs name, or None.

IMO, the name that was chosen for this function implies the opposite
of what it does (it implies that it returns the solib (base?) address).
I would personally prefer solib_name or solib_name_from_address.

> +for Python commands (@pxref{Commands In Python}). The expected
> +format of @var{expression} is:
> +
> +@table @code
> +@item FILE:LINENUM
> +A location indicated at that line in that file.
> +@item FUNCTION
> +A location at the beginning of that function.
> +@item FILE:FUNCTION
> +A location to distinguish among like-named static functions.
> +@item ADDRESS
> +A location containing that address.
> +@item VARIABLE
> +A location containing that variable.
> +@end table
> +@end defun

ISTM that we would be better off not duplicating the various forms
a linespec can take. How about using a cross reference?

--
Joel