Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: GDB Administrator <gdbadmin@sourceware.org>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Jul 14 01:55:54 UTC 2010
Date: Tue, 27 Jul 2010 16:18:00 -0000	[thread overview]
Message-ID: <20100727161823.GE13267@adacore.com> (raw)
In-Reply-To: <20100714015555.GA13409@sourceware.org>

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

> > gdb/dwarf2read.c:2284: gettext: trailing new line: A message should not have a trailing new line
> gdb/dwarf2read.c:2284:    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),

I fixed that one thusly.  The warning seems incorrectly phrased, but
I left it alone.

2010-07-27  Joel Brobecker  <brobecker@adacore.com>

        * dwarf2read.c (dw2_find_pc_sect_symtab): Remove trailing newline
        in warning message.

-- 
Joel

[-- Attachment #2: dwarf2read.c.diff --]
[-- Type: text/x-diff, Size: 677 bytes --]

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.427
diff -u -u -p -r1.427 dwarf2read.c
--- dwarf2read.c	27 Jul 2010 07:57:49 -0000	1.427
+++ dwarf2read.c	27 Jul 2010 16:15:27 -0000
@@ -2394,7 +2394,7 @@ dw2_find_pc_sect_symtab (struct objfile 
     return NULL;
 
   if (warn_if_readin && data->v.quick->symtab)
-    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),
+    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)"),
 	     paddress (get_objfile_arch (objfile), pc));
 
   return dw2_instantiate_symtab (objfile, data);

  reply	other threads:[~2010-07-27 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14  1:56 GDB Administrator
2010-07-27 16:18 ` Joel Brobecker [this message]
2010-07-29 21:01   ` Tom Tromey
2010-07-29 21:36     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100727161823.GE13267@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdbadmin@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox