From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24178 invoked by alias); 27 Jul 2010 14:43:24 -0000 Received: (qmail 24153 invoked by uid 22791); 27 Jul 2010 14:43:23 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Jul 2010 14:43:17 +0000 Received: (qmail 12986 invoked from network); 27 Jul 2010 14:43:15 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jul 2010 14:43:15 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Correct origin calculation of command line window in TUI mode Date: Tue, 27 Jul 2010 14:43:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-24-generic; KDE/4.4.2; x86_64; ; ) Cc: Balazs Kezes References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007271543.13838.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00421.txt.bz2 On Wednesday 21 July 2010 22:02:13, Balazs Kezes wrote: > The locator's (a small bar between source and command window) origin (the first > row's index) is not updated in tui_resize_all and this outdated data is used to > calculate the command window's origin. This patch fixes this by updating it. Hmmm, I've tried all three patches together, and I still get a messed up cmd window after a couple of resizes (e.g., start maxized/unmaximize/maximize). With just the "call tui_resize_all" patch applied, and the one below in addition, I get somewhat better result than with them all applied. Do you see something like that too? Makes me wonder where's the code that calculates all the initial sub window sizes for first display, and whether we could make more reuse out of it. > > -- > Balazs > > Index: tui-win.c > =================================================================== > RCS file: /cvs/src/src/gdb/tui/tui-win.c,v > retrieving revision 1.47 > diff -c -p -r1.47 tui-win.c > *** tui-win.c 17 May 2010 22:21:43 -0000 1.47 > --- tui-win.c 21 Jul 2010 20:56:49 -0000 > *************** tui_resize_all (void) > *** 712,717 **** > --- 712,718 ---- > else > new_height = first_win->generic.height + split_diff; > > + locator->origin.y = new_height + 1; > make_invisible_and_set_new_height (first_win, new_height); > TUI_CMD_WIN->generic.origin.y = locator->origin.y + 1; > TUI_CMD_WIN->generic.width += width_diff; > -- Pedro Alves