Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Do not break while asking with -batch
Date: Fri, 23 Jul 2010 17:06:00 -0000	[thread overview]
Message-ID: <20100723170635.GA8959@host1.dyn.jankratochvil.net> (raw)

Hi,

there was PR 9591 which originated from a request to safely `gdb_gcore.sh'
even from a very small terminal window.

FSF GDB HEAD currently still asks in such window
	---Type <return> to continue, or q <return> to quit---
and aborts.

OK to check-in?

No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.


Thanks,
Jan


gdb/
2010-07-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* utils.c (prompt_for_continue): Return on BATCH_FLAG or not
	INPUT_FROM_TERMINAL_P.

--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -2155,6 +2155,9 @@ prompt_for_continue (void)
   char *ignore;
   char cont_prompt[120];
 
+  if (batch_flag || ! input_from_terminal_p ())
+    return;
+
   if (annotation_level > 1)
     printf_unfiltered (("\n\032\032pre-prompt-for-continue\n"));
 


             reply	other threads:[~2010-07-23 17:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 17:06 Jan Kratochvil [this message]
2010-07-23 17:40 ` Tom Tromey
2010-07-23 18:09   ` Jan Kratochvil
2010-07-23 22:41     ` Tom Tromey
2010-07-27 16:35       ` Joel Brobecker
2010-07-27 19:17         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100723170635.GA8959@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox