From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74406-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8175 invoked by alias); 20 Jul 2010 12:51:16 -0000
Received: (qmail 8153 invoked by uid 22791); 20 Jul 2010 12:51:16 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Jul 2010 12:51:08 +0000
Received: (qmail 29444 invoked from network); 20 Jul 2010 12:51:06 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 20 Jul 2010 12:51:06 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH]prec: record_arch_list_add_mem add check for len
Date: Tue, 20 Jul 2010 12:51:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.31-11-rt; KDE/4.4.2; x86_64; ; )
Cc: Hui Zhu <teawater@gmail.com>
References: <AANLkTiksyvVzkAiwf1Rh3yDfiY4aSsN21RwoJPBkajES@mail.gmail.com>
In-Reply-To: <AANLkTiksyvVzkAiwf1Rh3yDfiY4aSsN21RwoJPBkajES@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201007201351.04862.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00297.txt.bz2

On Monday 19 July 2010 09:08:17, Hui Zhu wrote:
> Add this check for some code maybe len < 0.

How can len < 0 happen?  Wouldn't that be a bug?

> 
> Thanks,
> Hui
> 
> 2010-07-16  Hui Zhu  <teawater@gmail.com>
> 
> 	* record.c (record_arch_list_add_mem): Add check for len.
> 
> 
> ---
>  record.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/record.c
> +++ b/record.c
> @@ -497,6 +497,8 @@ record_arch_list_add_mem (CORE_ADDR addr
> 
>    if (!addr)	/* FIXME: Why?  Some arch must permit it... */
>      return 0;
> +  if (len <= 0)
> +    return 0;
> 
>    rec = record_mem_alloc (addr, len);
> 


-- 
Pedro Alves