From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix linux-nat.c {,lp->}status typo
Date: Tue, 20 Jul 2010 12:22:00 -0000 [thread overview]
Message-ID: <201007201322.28556.pedro@codesourcery.com> (raw)
In-Reply-To: <20100718145110.GA16697@host1.dyn.jankratochvil.net>
On Sunday 18 July 2010 15:51:12, Jan Kratochvil wrote:
> while reading the code I found this suspicious code, IMO a typo.
>
> if (WIFSTOPPED (lp->status))
> {
> if (WSTOPSIG (lp->status) != SIGSTOP)
> [...]
> }
> else if (WIFEXITED (status) || WIFSIGNALED (status))
> [...]
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
> (I haven't tried to find an impact of this bug.)
In practice, status == lp->status at this point for !WIFSTOPPED,
so there should be no impact.
> 2010-07-18 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * linux-nat.c (linux_nat_wait_1): Reset STATUS after calling
> linux_nat_wait_1. Use always LP->STATUS afterwards.
Okay, thanks.
--
Pedro Alves
next prev parent reply other threads:[~2010-07-20 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 14:51 Jan Kratochvil
2010-07-20 12:22 ` Pedro Alves [this message]
2010-07-20 12:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007201322.28556.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox