Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix linux-nat.c new_lp dropped status
Date: Tue, 20 Jul 2010 12:56:00 -0000	[thread overview]
Message-ID: <20100720125620.GA12185@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201007201346.21224.pedro@codesourcery.com>

On Tue, 20 Jul 2010 14:46:20 +0200, Pedro Alves wrote:
> On Sunday 18 July 2010 23:08:53, Jan Kratochvil wrote:
> It does to me.  Okay, thanks.

Checked-in, with a forgotten ChangeLog entry this time.


> > No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
                                                     ^^=13 in my recent mails.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-07/msg00113.html

--- src/gdb/ChangeLog	2010/07/20 12:33:29	1.12001
+++ src/gdb/ChangeLog	2010/07/20 12:54:57	1.12002
@@ -1,5 +1,10 @@
 2010-07-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* linux-nat.c (linux_handle_extended_wait): Handle case when
+	event == PTRACE_EVENT_CLONE && stopping && WSTOPSIG (status) != SIGSTOP.
+
+2010-07-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	Code cleanup.
 	* linux-nat.c (linux_nat_wait_1): Reset STATUS after calling
 	linux_nat_wait_1.  Use always LP->STATUS afterwards.
--- src/gdb/linux-nat.c	2010/07/20 12:33:30	1.175
+++ src/gdb/linux-nat.c	2010/07/20 12:54:57	1.176
@@ -2279,6 +2279,23 @@
 	      linux_ops->to_resume (linux_ops, pid_to_ptid (new_pid),
 				    0, signo);
 	    }
+	  else
+	    {
+	      if (status != 0)
+		{
+		  /* We created NEW_LP so it cannot yet contain STATUS.  */
+		  gdb_assert (new_lp->status == 0);
+
+		  /* Save the wait status to report later.  */
+		  if (debug_linux_nat)
+		    fprintf_unfiltered (gdb_stdlog,
+					"LHEW: waitpid of new LWP %ld, "
+					"saving status %s\n",
+					(long) GET_LWP (new_lp->ptid),
+					status_to_str (status));
+		  new_lp->status = status;
+		}
+	    }
 
 	  if (debug_linux_nat)
 	    fprintf_unfiltered (gdb_stdlog,


      reply	other threads:[~2010-07-20 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-18 22:09 Jan Kratochvil
2010-07-20 12:46 ` Pedro Alves
2010-07-20 12:56   ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720125620.GA12185@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox