Re: [RFA] Nullified garbage-collected global variables

Jerome Guitton
2010-07-26T09:33:18Z

Tom Tromey (tromey@redhat.com):

> Jerome> * dwarf2read.c (add_partial_symbol): Do not add a global variable if
> Jerome> its adress is null. Add comment to explain why.
> Jerome> (new_symbol): Ditto.
>
> Looks ok to me.

This has now been committed.

> FWIW -- I prefer it if a fix and its corresponding test case are
> submitted and committed as a unit. I think it is more logical, and also
> the test case sometimes helps the review of the patch.

That makes perfect sense. I will do that in the future.

Thank you
Jerome