From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix bug when debugging prelink'd library
Date: Mon, 12 Jul 2010 19:47:00 -0000 [thread overview]
Message-ID: <20100712194738.GA6846@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m38w5gwl37.fsf@fleche.redhat.com>
On Mon, 12 Jul 2010 21:34:20 +0200, Tom Tromey wrote:
> This fixes the problem by changing dwarf2_per_cu_objfile to return the
> debuginfo objfile. This appears to be correct for all callers except
> one, which I also updated.
As I find the API difficult to figure out which variant of `struct objfile *'
there is I tried to unify it - choosing the variant (A) described at:
[patch 12/15] PIE: Support loading PIEs from core files
http://sourceware.org/ml/gdb-patches/2009-11/msg00179.html
The patch below follows none of the (A)/(B)/(C) rules. In such case I miss at
least some fat comment at dwarf2_per_cu_objfile stating it returns non-primary
objfile variant.
dwarf2_per_cu_objfile result is in most cases used only for get_objfile_arch
(should not matter) and
CORE_ADDR base_offset = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
so there could be rather function dwarf2_per_cu_base_offset.
Regards,
Jan
next prev parent reply other threads:[~2010-07-12 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 19:34 Tom Tromey
2010-07-12 19:47 ` Jan Kratochvil [this message]
2010-07-12 20:24 ` Tom Tromey
2010-07-12 21:06 ` Tom Tromey
2010-07-12 21:22 ` Jan Kratochvil
2010-07-13 15:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712194738.GA6846@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox