From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10807 invoked by alias); 7 Jul 2010 12:25:07 -0000 Received: (qmail 10793 invoked by uid 22791); 7 Jul 2010 12:25:06 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.17.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jul 2010 12:25:00 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id o67COvI9031307 for ; Wed, 7 Jul 2010 12:24:57 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o67COuc91867822 for ; Wed, 7 Jul 2010 14:24:56 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o67COuVE014746 for ; Wed, 7 Jul 2010 14:24:56 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o67COtto014736; Wed, 7 Jul 2010 14:24:55 +0200 Message-Id: <201007071224.o67COtto014736@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 07 Jul 2010 14:24:55 +0200 Subject: Re: [PATCH 2/4] Hardware accelerated watchpoint conditions To: bauerman@br.ibm.com (Thiago Jung Bauermann) Date: Wed, 07 Jul 2010 12:25:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org, luisgpm@linux.vnet.ibm.com (Luis Machado), tyrlik@us.ibm.com (Matt Tyrlik) In-Reply-To: <1278454947.2544.9.camel@hactar> from "Thiago Jung Bauermann" at Jul 06, 2010 07:22:27 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00108.txt.bz2 Thiago Jung Bauermann wrote: > 2010-07-06 Sergio Durigan Junior > Thiago Jung Bauermann > > * breakpoint.c (fetch_watchpoint_value): Rename to fetch_subexp_value > and move to eval.c. Change callers. > (insert_bp_location): Pass watchpoint condition in > target_insert_watchpoint. > (remove_breakpoint_1) Pass watchpoint condition in > target_remove_watchpoint. > (watchpoint_locations_match): Call > target_can_accel_watchpoint_condition. > * eval.c: Include wrapper.h. > (fetch_subexp_value): Moved from breakpoint.c. > * ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): > Formatting fix. > (can_use_watchpoint_cond_accel): New function. > (calculate_dvc): Likewise. > (num_memory_accesses): Likewise. > (check_condition): Likewise. > (ppc_linux_can_accel_watchpoint_condition): Likewise > (ppc_linux_insert_watchpoint): Call can_use_watchpoint_cond_accel, > check_condition and calculate_dvc. > (ppc_linux_remove_watchpoint): Likewise. > (_initialize_ppc_linux_nat): Set to_can_accel_watchpoint_condition to > ppc_linux_can_accel_watchpoint_condition > * target.c (debug_to_insert_watchpoint): Add argument for watchpoint > condition. > (debug_to_remove_watchpoint): Likewise. > (debug_to_can_accel_watchpoint_condition): New function. > (update_current_target): Set to_can_accel_watchpoint_condition. > (setup_target_debug): Set to_can_accel_watchpoint_condition. > * target.h: Add opaque declaration for struct expression. > (struct target_ops) , > : Add new arguments to pass the watchpoint > : New member. > condition. Update all callers and implementations. > (target_can_accel_watchpoint_condition): New macro. > * value.c (free_value_chain): New function. > * value.h (fetch_subexp_value): New prototype. > (free_value_chain): Likewise. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com