From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18960 invoked by alias); 6 Jul 2010 13:06:04 -0000 Received: (qmail 18867 invoked by uid 22791); 6 Jul 2010 13:06:02 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.17.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jul 2010 13:04:32 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id o66D4Ugi024634 for ; Tue, 6 Jul 2010 13:04:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o66D4Tpn1826860 for ; Tue, 6 Jul 2010 15:04:29 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o66D4TSV013392 for ; Tue, 6 Jul 2010 15:04:29 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o66D4Sbh013365; Tue, 6 Jul 2010 15:04:28 +0200 Message-Id: <201007061304.o66D4Sbh013365@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 06 Jul 2010 15:04:28 +0200 Subject: Re: [patch, libiberty, gdb] IEEE 754 half floating-point format To: ken@linux.vnet.ibm.com (Ken Werner), dj@redhat.com Date: Tue, 06 Jul 2010 13:06:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org In-Reply-To: <201007021859.05191.ken@linux.vnet.ibm.com> from "Ken Werner" at Jul 02, 2010 06:59:05 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00092.txt.bz2 Ken Werner wrote: > include/ChangeLog: > > 2010-07-02 Ken Werner > > * gfloatformat.h (floatformat_ieee_half_big): Add declaration. > (floatformat_ieee_half_little): Likewise. > > libiberty/ChangeLog: > > 2010-07-02 Ken Werner > > * floatformat.c (floatformat_ieee_half_big): New variable. > (floatformat_ieee_half_little): Likewise. > > ChangeLog: > > 2010-07-02 Ken Werner > > * gdbtypes.h (floatformats_ieee_half): Add declaration. > * gdbtypes.c (floatformats_ieee_half): New variable. > * doublest.c (floatformat_from_length): Set format to > gdbarch_half_format if length matches. > * gdbarch.sh (half_bit): New architecture method. > (half_format): Likewise. > * gdbarch.h: Regenerate. > * gdbarch.c: Likewise. DJ Delorie wrote: > The libiberty parts are OK. At least, they shouldn't break anything, > I have no idea if the *values* are correct. The GDB parts are OK as well. As far as the values go, they seem correct to me according to the IEEE spec and compared to GCC's real.c ... I've checked the patch in to the src and gcc repositories now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com