From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11959 invoked by alias); 5 Jul 2010 17:35:16 -0000 Received: (qmail 11947 invoked by uid 22791); 5 Jul 2010 17:35:15 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Jul 2010 17:35:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0E6402BAC50; Mon, 5 Jul 2010 13:35:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id imvg5244qVYk; Mon, 5 Jul 2010 13:35:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 73D802BAB8A; Mon, 5 Jul 2010 13:35:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C453CF5895; Mon, 5 Jul 2010 10:34:52 -0700 (PDT) Date: Mon, 05 Jul 2010 17:35:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: ping: [patch 4/6] testsuite: Unify to lib/prelink-support.exp Message-ID: <20100705173452.GB2595@adacore.com> References: <20100329161753.GC2940@host0.dyn.jankratochvil.net> <20100609150923.GD7183@host0.dyn.jankratochvil.net> <20100629215558.GU2595@adacore.com> <20100704101823.GD6875@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100704101823.GD6875@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00081.txt.bz2 > gdb/testsuite/ > 2010-07-04 Jan Kratochvil > Joel Brobecker > > * gdb.base/attach-pie-misread.exp: Load prelink-support.exp. Replace > build_executable by build_executable_own_libs. Replace "prelink -R" > execution by a call of prelink_yes. Comment why "prelink -r" needs no > change. > * gdb.base/break-interp.exp: Load prelink-support.exp. Rename calls of > copy to file_copy. Move setting opts --dynamic-linker and -rpath, > mkdir $dir and ldd its parsing and copying to lib/prelink-support.exp. > Replace build_executable by build_executable_own_libs's function > build_executable_own_libs. > (prelinkNO): Create new stub to call prelink_no. > (prelinkYES): Create new stub to call prelink_yes. > (test_attach): Rename calls of copy to file_copy. > (section_get, prelinkNO_run, prelinkNO, prelinkYES, symlink_resolve) > (copy): Move to ... > * lib/prelink-support.exp: ... a new file. Rename prelinkNO to > prelink_no, prelinkYES to prelink_yes, copy to file_copy. > * gdb.base/prelink.exp: Disable testcase also for is_remote and > skip_shlib_tests. Load prelink-support.exp. Replace gdb_compile with > special flags by gdb_compile_shlib. Replace second gdb_compile by > build_executable_own_libs. Replace "prelink -R" execution by a call of > prelink_yes. Replace "prelink -u" and second "prelink -R" execution by > a second call of prelink_yes. Replace restart commands by > clean_restart. > (prelink): Rename to ... > (seen displacement message): ... this test. Extend its expectation > strictness. OK to commit. > + # For normal prelink (prelink_yes call) we need to supply $prelink_args. > + # For the prelink `-r' option below $prelink_args is not required. > + # Moreover if it would be used the problem would not longer be reproducible > + # as the libraries would also get relocated. Minor editorial changes (mostly adding comas)... # For normal prelink (prelink_yes call), we need to supply $prelink_args. # For the prelink `-r' option below, $prelink_args is not required. # Moreover, if it was used, the problem would not longer be reproducible # as the libraries would also get relocated. -- Joel