Re: New ARI warning Fri Jul 2 01:53:49 UTC 2010

Joel Brobecker
2010-07-28T18:07:49Z

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

> > gdb/remote.c:2787: code: sprintf: Do not use sprintf, instead use xstrprintf
> gdb/remote.c:2787: sprintf (p, ');
> 1161a1163
> > gdb/remote.c:9747: gettext: _ markup: All messages should be marked up with _.
> gdb/remote.c:9747: error ("Static tracepoint not valid during download");
> 1450,1451d1451
> > gdb/tracepoint.c:4133: gettext: _ markup: All messages should be marked up with _.
> gdb/tracepoint.c:4133: error ("bad marker definition: %s", line);

I fixed those thusly. I don't know how to say this without sounding
like I am complaining, but I had hoped that we would all look at those
reports and that whoever caused the new warnings would act to fix them.

--
Joel

[-- Attachment #2: ari.diff --]
[-- Type: text/x-diff, Size: 1846 bytes --]

commit fe7232e92fa10789ade5a9d414b5e61e30463523
Author: Joel Brobecker <brobecker@adacore.com>
Date: Wed Jul 28 11:03:34 2010 -0700

Add missing gettext markup.

gdb/ChangeLog:

* remote.c (remote_download_tracepoint): Add missing gettext markup.
* tracepoint.c (parse_static_tracepoint_marker_definition): Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 630de2d..e74823c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2010-07-28 Joel Brobecker <brobecker@adacore.com>

+ * remote.c (remote_download_tracepoint): Add missing gettext markup.
+ * tracepoint.c (parse_static_tracepoint_marker_definition): Likewise.
+
+2010-07-28 Joel Brobecker <brobecker@adacore.com>
+
* breakpoint.c (breakpoint_re_set_one): Move call to set_language
down, just before the block that parse the breakpoint addr_string.

diff --git a/gdb/remote.c b/gdb/remote.c
index 71eee5d..e42e57f 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -9746,7 +9746,7 @@ remote_download_tracepoint (struct breakpoint *t)
if (target_static_tracepoint_marker_at (tpaddr, &marker))
strcat (buf, ":S");
else
- error ("Static tracepoint not valid during download");
+ error (_("Static tracepoint not valid during download"));
}
else
/* Fast tracepoints are functionally identical to regular
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index 80be63e..b8b9d8c 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -4128,7 +4128,7 @@ parse_static_tracepoint_marker_definition (char *line, char **pp,

endp = strchr (p, ':');
if (endp == NULL)
- error ("bad marker definition: %s", line);
+ error (_("bad marker definition: %s"), line);

marker->str_id = xmalloc (endp - p + 1);
end = hex2bin (p, (gdb_byte *) marker->str_id, (endp - p + 1) / 2);