From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8426 invoked by alias); 1 Jul 2010 17:13:11 -0000 Received: (qmail 8418 invoked by uid 22791); 1 Jul 2010 17:13:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 17:13:05 +0000 Received: (qmail 6700 invoked from network); 1 Jul 2010 17:13:03 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jul 2010 17:13:03 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: Static tracepoints support Date: Thu, 01 Jul 2010 17:13:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.31-10-rt; KDE/4.4.2; x86_64; ; ) References: <201006251931.57860.pedro@codesourcery.com> <201007011500.27076.pedro@codesourcery.com> <83pqz79lhg.fsf@gnu.org> In-Reply-To: <83pqz79lhg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201007011813.02237.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00024.txt.bz2 On Thursday 01 July 2010 18:10:19, Eli Zaretskii wrote: > > From: Pedro Alves > > Date: Thu, 1 Jul 2010 15:00:26 +0100 > > Cc: Eli Zaretskii > > > > On Monday 28 June 2010 13:26:38, Pedro Alves wrote: > > > > > +with that name. With no LOCATION, uses current execution address of \n\ > > > > > +selected stack frame.\n\ > > > > > > > > "of the selected stack frame" > > > > > > Fixed. Needs fixing in BREAK_ARGS_HELP; it's showing up in the help > > > strings of all breakpoint commands. > > > > > > > Here's the fix for all other breakpoint commands, but I do > > note some sort of pattern here: it appears that "the" was > > avoided on purpose in all the sentences as can be seen in > > the contenxt of the patch. Would you like to review > > the whole help string, or is this correct? > > "the selected stack frame" is correct here. Okay, though I was more trying to suggest to check if the other "the"'s are actually missing, like "With no LOCATION, uses _the_ current execution address of _the_ selected frame", and "break at _the_ start of code for that function". I'll apply the patch once I adjust the testsuite accordinly (help.exp). -- Pedro Alves