From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
'Doug Evans' <dje@google.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA]dwarf reader: Avoid complaint on const type
Date: Thu, 01 Jul 2010 17:13:00 -0000 [thread overview]
Message-ID: <20100701171256.GW2595@adacore.com> (raw)
In-Reply-To: <201007011808.55025.pedro@codesourcery.com>
> I hope you're not waiting for me to review this. (Honestly, in cases
> like these, I prefer to simply revert the original broken patch, and
> then calmly build a new correct patch from scratch. It becomes
> much easier to see and understand what was being addressed originaly
> instead of having to look at the code in 3D. I've noticed that
> people here have revert fobia though ;-) ).
Agreed on both counts - we should not be reluctant to revert.
--
Joel
next prev parent reply other threads:[~2010-07-01 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41597.7287375883$1274454923@news.gmane.org>
2010-05-21 17:20 ` Tom Tromey
2010-05-21 20:46 ` Pierre Muller
2010-06-16 16:08 ` Pedro Alves
2010-06-20 22:39 ` Pierre Muller
[not found] ` <3752333521215815628@unknownmsgid>
2010-06-28 20:27 ` Doug Evans
2010-06-29 13:09 ` Pierre Muller
2010-07-01 17:09 ` Pedro Alves
2010-07-01 17:13 ` Joel Brobecker [this message]
2010-07-21 17:16 ` Pedro Alves
[not found] ` <29342.6726283089$1277816998@news.gmane.org>
2010-07-02 21:47 ` Tom Tromey
2010-05-21 15:31 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701171256.GW2595@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox