From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8930 invoked by alias); 1 Jul 2010 15:41:11 -0000 Received: (qmail 8920 invoked by uid 22791); 1 Jul 2010 15:41:10 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 15:41:06 +0000 Received: (qmail 15403 invoked from network); 1 Jul 2010 15:41:04 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jul 2010 15:41:04 -0000 Date: Thu, 01 Jul 2010 15:41:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs Message-ID: <20100701154058.GA25227@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00012.txt.bz2 On Wed, Jun 30, 2010 at 04:37:23PM -0600, Tom Tromey wrote: > This patch changes dwarf2_frame_find_fde to check psymtabs_addrmap > before trying to read the FDE data. > > I am not totally convinced this is safe, so comments are especially > appreciated here. This doesn't sound right. I don't know how any of the psymtab changes work, but there shouldn't be a link between psymtabs and FDEs at all; they don't have to correspond. Wouldn't this break a library with .debug_frame for all code, and .debug_info for only one input object? -- Daniel Jacobowitz CodeSourcery