From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: Static tracepoints support
Date: Thu, 01 Jul 2010 10:41:00 -0000 [thread overview]
Message-ID: <201007011141.23018.pedro@codesourcery.com> (raw)
In-Reply-To: <8339w4bd3q.fsf@gnu.org>
On Wednesday 30 June 2010 19:16:09, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>
> > Here's a new version of the patch integrating all of the
> > above. Any further comments?
>
> Just three:
>
> > + $_sdata internal variable. When analying the trace buffer, you can
> ^^^^^^^^
> A typo (sorry I didn't catch that before).
>
> > +Whether the breakpoint is marked to be disabled or deleted when hit.
>
> Wasn't there supposed to be an @item before this sentence?
Arrh, copy&paste from "info breakpoints".. the sentence wasn't even
supposed to be there, I've removed it (it's describing breakpoint's
dispositions).
>
> > +UST backend, this is the the format string passed as argument to the
> ^^^
> Redundant "the".
>
> Okay with those changes.
Checked in with those changes. Thank you for the review!
--
Pedro Alves
next prev parent reply other threads:[~2010-07-01 10:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 18:33 Pedro Alves
2010-06-26 10:34 ` Eli Zaretskii
2010-06-28 12:28 ` Pedro Alves
2010-06-28 20:03 ` Eli Zaretskii
2010-06-29 21:00 ` Pedro Alves
2010-06-30 18:14 ` Eli Zaretskii
2010-07-01 10:41 ` Pedro Alves [this message]
2010-07-01 14:22 ` clarify "help break" output a bit (Re: Static tracepoints support) Pedro Alves
2010-07-01 17:10 ` Eli Zaretskii
2010-06-28 20:04 ` Static tracepoints support Eli Zaretskii
2010-07-01 13:50 ` el vs ell (Re: Static tracepoints support) Pedro Alves
2010-07-01 16:26 ` Michael Snyder
2010-07-01 17:07 ` Eli Zaretskii
2010-07-01 17:28 ` Pedro Alves
2010-07-01 14:00 ` Static tracepoints support Pedro Alves
2010-07-01 17:08 ` Eli Zaretskii
2010-07-01 17:13 ` Pedro Alves
2010-07-01 14:15 ` add a few index entries (Re: Static tracepoints support) Pedro Alves
2010-07-01 17:09 ` Eli Zaretskii
2010-07-01 15:38 ` remove redundant blank from strings " Pedro Alves
2010-07-01 17:11 ` Eli Zaretskii
2010-07-01 16:36 ` dynamic type column width in "info breakpoints" output " Pedro Alves
2010-07-01 17:17 ` Eli Zaretskii
2010-07-02 21:35 ` Tom Tromey
2010-07-21 11:30 ` Pedro Alves
2010-06-27 22:47 ` Static tracepoints support Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007011141.23018.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox