From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6120 invoked by alias); 28 Jun 2010 20:19:55 -0000 Received: (qmail 5980 invoked by uid 22791); 28 Jun 2010 20:19:54 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_YY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Jun 2010 20:19:50 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5SKJmHJ004364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Jun 2010 16:19:49 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5SKJkV7031180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Jun 2010 16:19:48 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5SKJkAF021536; Mon, 28 Jun 2010 22:19:46 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5SKJjSq021535; Mon, 28 Jun 2010 22:19:45 +0200 Date: Mon, 28 Jun 2010 20:19:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org, Sami Wagiaalla Subject: Re: [patch] Fix C++ leading :: (PR c++/11703 and PR gdb/1448) Message-ID: <20100628201945.GA21190@host0.dyn.jankratochvil.net> References: <20100626082205.GA30439@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00661.txt.bz2 On Mon, 28 Jun 2010 20:28:27 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > Jan> 2010-06-26 Jan Kratochvil > Jan> Fix PR c++/11703 and PR gdb/1448. > Jan> * c-exp.y (yylex) : Add > Jan> FIRST_ITER check. > > Jan> 2010-06-26 Jan Kratochvil > Jan> Test PR c++/11703 and PR gdb/1448. > Jan> * gdb.cp/namespace.exp (whatis ::C::cOtherFileVar) > Jan> (print ::C::cOtherFileVar) > Jan> (print ::C::OtherFileClass::cOtherFileClassVar): Remove KFAIL for > Jan> c++/11703. > Jan> (ptype ::C::NestedClass): Remove KFAIL for gdb/1448. > > This is ok. Thanks for fixing this. Checked-in. Simlified patches order so the gdb/testsuite/ change is reduced. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-06/msg00197.html --- src/gdb/ChangeLog 2010/06/28 20:12:52 1.11942 +++ src/gdb/ChangeLog 2010/06/28 20:18:26 1.11943 @@ -1,5 +1,11 @@ 2010-06-28 Jan Kratochvil + Fix PR c++/11703 and PR gdb/1448. + * c-exp.y (yylex) : Add + FIRST_ITER check. + +2010-06-28 Jan Kratochvil + Fix modification of cplus_struct_default. * dwarf2read.c (dwarf2_add_member_fn) : Call ALLOCATE_CPLUS_STRUCT_TYPE. --- src/gdb/c-exp.y 2010/05/07 14:46:25 1.75 +++ src/gdb/c-exp.y 2010/06/28 20:18:26 1.76 @@ -2553,7 +2553,7 @@ { token_and_value cc; memset (&cc, 0, sizeof (token_and_value)); - if (first_was_coloncolon) + if (first_was_coloncolon && first_iter) { yylval = cc.value; return COLONCOLON; --- src/gdb/testsuite/ChangeLog 2010/06/28 20:12:52 1.2359 +++ src/gdb/testsuite/ChangeLog 2010/06/28 20:18:26 1.2360 @@ -1,5 +1,11 @@ 2010-06-28 Jan Kratochvil + Test PR c++/11703 and PR gdb/1448. + * gdb.cp/namespace.exp (ptype ::C::NestedClass): Remove KFAIL for + gdb/1448. + +2010-06-28 Jan Kratochvil + * gdb.cp/virtbase.cc (class RTTI_base, class RTTI_data) (main) : New. * gdb.cp/virtbase.exp (print rtti_data): New. --- src/gdb/testsuite/gdb.cp/namespace.exp 2010/06/01 18:18:35 1.19 +++ src/gdb/testsuite/gdb.cp/namespace.exp 2010/06/28 20:18:27 1.20 @@ -192,7 +192,6 @@ gdb_test "ptype NestedClass" "No symbol \"NestedClass\" in current context." gdb_test "ptype ::C::CClass" "type = class C::CClass \{\r\n public:\r\n int x;\r\n\}" gdb_test "ptype ::C::CClass::NestedClass" "type = class C::CClass::NestedClass \{\r\n public:\r\n int y;\r\n\}" -setup_kfail "gdb/1448" "*-*-*" gdb_test "ptype ::C::NestedClass" "No symbol \"NestedClass\" in namespace \"C\"." gdb_test "ptype C::CClass" "No symbol \"CClass\" in namespace \"C::C\"." gdb_test "ptype C::CClass::NestedClass" "No type \"CClass\" within class or namespace \"C::C\"."