Re: [patch] testsuite: Error on trailing newlines

Jan Kratochvil
2010-06-04T14:31:28Z

On Thu, 03 Jun 2010 01:02:35 +0200, Joel Brobecker wrote:
> > * gdb.base/commands.exp (add printf tbreak command): Remove trailing
> > newline.
> > * gdb.gdb/complaints.exp (empty non-verbose non-noisy clear)
> > (empty verbose non-noisy clear, empty verbose noisy clear)
> > (empty non-verbose noisy clear): Likewise.
>
> This part is definitely OK (you've treated them as obvious so far).
> So let's commit them now.

True, checked-in.

> Invalid trailing newline in \"$message\" test
>
> ? I don't mind the gdb_test_multiple in the error message if you think
> it makes a difference, but I can see how it can confuse people who are
> not familiar with the testsuite infrastructure if the test was written
> using gdb_test...

I do not mind that message change, thanks.

Regards,
Jan

http://sourceware.org/ml/gdb-cvs/2010-06/msg00040.html

--- src/gdb/testsuite/ChangeLog 2010/06/03 23:54:17 1.2313
+++ src/gdb/testsuite/ChangeLog 2010/06/04 14:26:47 1.2314
@@ -1,3 +1,11 @@
+2010-06-04 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/commands.exp (add printf tbreak command): Remove trailing
+ newline.
+ * gdb.gdb/complaints.exp (empty non-verbose non-noisy clear)
+ (empty verbose non-noisy clear, empty verbose noisy clear)
+ (empty non-verbose noisy clear): Likewise.
+
2010-06-03 Michael Snyder <msnyder@vmware.com>

* gdb.base/commands.exp: Replace gdb_test with gdb_test_no_output.
--- src/gdb/testsuite/gdb.base/commands.exp 2010/06/03 23:54:17 1.38
+++ src/gdb/testsuite/gdb.base/commands.exp 2010/06/04 14:26:49 1.39
@@ -503,7 +503,7 @@
pass "add silent tbreak command"
}
}
- gdb_test_multiple "printf \"factorial tbreak commands executed\\n\"\n" \
+ gdb_test_multiple "printf \"factorial tbreak commands executed\\n\"" \
"add printf tbreak command" {
-re ">$" {
pass "add printf tbreak command"
--- src/gdb/testsuite/gdb.gdb/complaints.exp 2010/05/26 18:31:25 1.13
+++ src/gdb/testsuite/gdb.gdb/complaints.exp 2010/06/04 14:26:52 1.14
@@ -207,13 +207,13 @@

proc test_empty_complaints { } {

- test_empty_complaint "call clear_complaints(&symfile_complaints,0,0)\n" \
+ test_empty_complaint "call clear_complaints(&symfile_complaints,0,0)" \
"empty non-verbose non-noisy clear"
- test_empty_complaint "call clear_complaints(&symfile_complaints,1,0)\n" \
+ test_empty_complaint "call clear_complaints(&symfile_complaints,1,0)" \
"empty verbose non-noisy clear"
- test_empty_complaint "call clear_complaints(&symfile_complaints,1,1)\n" \
+ test_empty_complaint "call clear_complaints(&symfile_complaints,1,1)" \
"empty verbose noisy clear"
- test_empty_complaint "call clear_complaints(&symfile_complaints,0,1)\n" \
+ test_empty_complaint "call clear_complaints(&symfile_complaints,0,1)" \
"empty non-verbose noisy clear"

return 0